Opened 4 years ago

Last modified 4 years ago

#60986 closed enhancement

mame @0.206 Variant proposal to install mame tools and man pages — at Version 3

Reported by: rhuelga (Roberto Huelga) Owned by:
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: mame

Description (last modified by rhuelga (Roberto Huelga))

I have modified the portfile to create a variant +tools that compile and install some of the mame tools and their man pages:

  • castool
  • chdman
  • floptool
  • imgtool
  • jedutil
  • ldresample
  • ldverify
  • romcmp

It's interesting to note that other commands get compiled, maybe some of them worth to be installed too.

  • aueffectutil
  • nltool
  • nlwav
  • pngcmp
  • regrep
  • split
  • src2html
  • srcclean
  • unidasm
--- Portfile.orig       2019-12-02 19:32:36.000000000 +0100
+++ Portfile    2020-08-11 11:19:44.000000000 +0200
@@ -82,8 +82,33 @@
     set executable  mame
 }

+variant tools description {compile and install the mame tools like chdman and others} {
+    build.args-append  TOOLS=1
+}
+
 destroot {
     xinstall ${worksrcpath}/${executable} ${destroot}${prefix}/bin
+    xinstall ${worksrcpath}/docs/man/mame.6 ${destroot}${prefix}/share/man/man6
+
+    if {[variant_isset tools]} {
+        xinstall ${worksrcpath}/castool \
+            ${worksrcpath}/chdman \
+            ${worksrcpath}/floptool \
+            ${worksrcpath}/imgtool \
+            ${worksrcpath}/jedutil \
+            ${worksrcpath}/ldresample \
+            ${worksrcpath}/ldverify \
+            ${worksrcpath}/romcmp ${destroot}${prefix}/bin
+
+        xinstall ${worksrcpath}/docs/man/castool.1 \
+            ${worksrcpath}/docs/man/chdman.1 \
+            ${worksrcpath}/docs/man/floptool.1 \
+            ${worksrcpath}/docs/man/imgtool.1 \
+            ${worksrcpath}/docs/man/jedutil.1 \
+            ${worksrcpath}/docs/man/ldresample.1 \
+            ${worksrcpath}/docs/man/ldverify.1 \
+            ${worksrcpath}/docs/man/romcmp.1 ${destroot}${prefix}/share/man/man1
+    }
 }

 # Universal variant is untested

Change History (5)

Changed 4 years ago by rhuelga (Roberto Huelga)

Attachment: Portfile added

Portfile mame with +tools variant

comment:1 Changed 4 years ago by rhuelga (Roberto Huelga)

Description: modified (diff)

comment:2 Changed 4 years ago by mf2k (Frank Schima)

Thanks. Per the guidelines, please instead attach a unified diff of the Portfile. Or better yet, submit a GitHub pull request.

I see no reason to make this a variant. Just always do that.

Last edited 4 years ago by mf2k (Frank Schima) (previous) (diff)

Changed 4 years ago by rhuelga (Roberto Huelga)

Attachment: Portfile-mame.diff added

Patch mame portfile

comment:3 Changed 4 years ago by rhuelga (Roberto Huelga)

Description: modified (diff)
Note: See TracTickets for help on using tickets.