Opened 4 years ago
Last modified 7 months ago
#61192 new defect
Lots of golang ports are downloading dependencies at build time — at Version 86
Reported by: | amake (Aaron Madlon-Kay) | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | breun (Nils Breunese), cardi (calvin ardi), dgsb (David Bariod), eborisch (Eric A. Borisch), harens (Haren S), herbygillot (Herby Gillot), lbschenkel (Leonardo Brondani Schenkel), mjrc, nickolaev, sirn (Kridsada Thanabulpong) | |
Port: | annie aws-vault certigo chezmoi cloudmonkey copilot croc elvish evans fzf gitqlite glow go-migrate golangci-lint gore gotop grpcurl hugo ipfs istioctl jenkins-cli k9s krew kubergrunt kustomize micro mole newreleases pulumi rclone scw staticcheck syncthing tektoncd-cli terragrunt trivy uni up webify wtfutil yq nebula qri |
Description (last modified by amake (Aaron Madlon-Kay))
With the introduction of the Go modules system, it's very easy to accidentally make a port that downloads dependencies at build time.
I want to add GOPROXY=off GO111MODULE=off
to build.env
to prevent this, but there are many ports that currently fail in my testing.
Discover ports using the golang-1.0 portgroup (currently 85):
find . -name Portfile | xargs grep -l -E 'PortGroup +golang' | xargs -n 1 dirname | xargs -n 1 basename
Of those, ports that failed to build with GOPROXY=off GO111MODULE=off
appended to build.env
:
port | maintainer | status |
---|---|---|
@l2dy,openmaintainer | fixed | |
@herbygillot,openmaintainer | fixed | |
@herbygillot,openmaintainer | fixed | |
@herbygillot,openmaintainer | fixed | |
@herbygillot,openmaintainer | fixed | |
copilot | @herbygillot,openmaintainer | Non-trivial: has a complicated asset generating step that relies on multiple golang tools that should be ports of their own: mockgen , packr2
|
@herbygillot,openmaintainer | fixed | |
@herbygillot,openmaintainer | fixed | |
@herbygillot,openmaintainer | fixed | |
@cardi,openmaintainer | fixed | |
@herbygillot,openmaintainer | fixed | |
@herbygillot,openmaintainer | fixed | |
go-migrate | @herbygillot,openmaintainer | Non-trivial: depends on multiple modules housed in same repo but with different versions |
golangci-lint | @herbygillot,openmaintainer | Non-trivial: import path error |
@herbygillot,openmaintainer | fixed | |
@i0ntempest,openmaintainer | fixed | |
grpcurl | @herbygillot,openmaintainer | Non-trivial: depends on multiple modules housed in same repo but with different versions |
hugo | @cardi,openmaintainer | Non-trivial: depends on multiple modules housed in same repo but with different versions |
ipfs | @sirn,openmaintainer | Non-trivial: extracted source file name collisions |
istioctl | @nickolaev,openmaintainer | due to #61184 |
@harens,openmaintainer | fixed | |
k9s | @breun,openmaintainer | Non-trivial: import path error |
@herbygillot,openmaintainer | fixed | |
kubergrunt | @herbygillot,openmaintainer | #61185; Non-trivial: import path error |
kustomize | @breun,openmaintainer | Non-trivial: depends on multiple modules housed in same repo but with different versions |
@herbygillot,openmaintainer | fixed | |
@herbygillot,openmaintainer | fixed | |
@herbygillot,openmaintainer | fixed | |
pulumi | @herbygillot,openmaintainer | Non-trivial: contains numerous dependencies from unsupported domains |
rclone | @eborisch,openmaintainer | Non-trivial: depends on multiple modules housed in same repo but with different versions |
scw | @dgsb,openmaintainer | pending |
@herbygillot,openmaintainer | fixed | |
syncthing | @lbschenkel,openmaintainer | pending |
tektoncd-cli | @herbygillot,openmaintainer | Non-trivial: contains numerous dependencies from unsupported domains |
terragrunt | @mjrc,openmaintainer | Non-trivial: depends on multiple modules housed in same repo but with different versions |
trivy | @herbygillot,openmaintainer | Non-trivial: contains numerous dependencies from unsupported domains |
@herbygillot,openmaintainer | fixed | |
@herbygillot,openmaintainer | fixed | |
@harens,openmaintainer | fixed | |
wtfutil | @herbygillot,openmaintainer | Non-trivial: contains numerous dependencies from unsupported domains |
@herbygillot,openmaintainer | fixed | |
@herbygillot,openmaintainer | fixed | |
qri | @herbygillot,openmaintainer | Non-trivial: depends on multiple modules housed in same repo but with different versions |
I have not yet checked that each of these failures is from being unable to download dependencies, as opposed to e.g. something more esoteric about GO111MODULE
.
Change History (90)
comment:1 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | herbygillot added |
---|
comment:2 Changed 4 years ago by herbygillot (Herby Gillot)
Thank you @ryandesign, @amake
I will look to transition more of the Go ports over time to using go.vendor
. It will be cumbersome, but will give it a go.
comment:3 Changed 4 years ago by herbygillot (Herby Gillot)
go2port
goes not seem to work very well... the checksums that it generates for go.vendor
don't always match what MacPorts sees.... so when attempting to build a Portfile derived from go2port
, the build process immediately fails on checksum mismatches.
comment:4 Changed 4 years ago by amake (Aaron Madlon-Kay)
go2port
is very much a "best effort" tool :(
I just had a go at fixing the glow
port here and noted the following tricky parts:
- go2port 20200217 will duplicate some dependencies. I just fixed this and pushed an update to the port, so you should see it soon.
- There were some checksum mismatches as you mentioned; surprisingly enough it seemed like GitHub sometimes served truncated tarballs, because deleting and re-downloading fixed it. This is quite troubling, but I'm not sure what I can do about it.
- Simply pasting the generated
go.vendors
block is not enough; you also have to give the main distfile a filename. Until you do so, the checksum phase will fail in a way that makes it look like issue (2) above.
One issue you might run into is that custom domains are generally not supported by either go2port
or the golang portgroup*. So far all the packages with custom domains I've seen have been mere redirects to a supported domain like github.com. If you encounter something else then it might be quite difficult to handle.
*Someone has offered a patch to support arbitrary domains in go2port
but since the golang portgroup would also need a lot of work I haven't yet properly reviewed it.
comment:5 Changed 4 years ago by mf2k (Frank Schima)
Cc: | @… @… @… @… @… @… @… @… @… @… @… @… added; herbygillot removed |
---|---|
Description: | modified (diff) |
Port: | annie aws-vault certigo chezmoi cloudmonkey copilot croc elvish evans fzf gitqlite glow go-migrate golangci-lint gore gotop grpcurl hugo ipfs istioctl jenkins-cli k9s krew kubergrunt kustomize micro mole newreleases pulumi rclone scw staticcheck syncthing tektoncd-cli terragrunt trivy uni up webify wtfutil yq added |
comment:6 Changed 4 years ago by Aaron Madlon-Kay <amake@…>
comment:7 Changed 4 years ago by herbygillot (Herby Gillot)
I feel like instead of having go2port
reinvent the wheel, we should download deps _exactly_ as Go would... and so perhaps the go mod download
command could be of some use here. The only downside is that Go seems to prefer using .zip files, which won't match MacPort's preferred .tar.gz suffix used in most places.
Within a Go project's source tree, go mod download -json
will print the manifest that Go would use to download the project's dependencies if that project is using Go modules. This can lead to a much more robust way for MacPorts to vendor the Go deps.
Sample output:
{ "Path": "cloud.google.com/go", "Version": "v0.26.0", "Info": "/Users/herby/go/pkg/mod/cache/download/cloud.google.com/go/@v/v0.26.0.info", "GoMod": "/Users/herby/go/pkg/mod/cache/download/cloud.google.com/go/@v/v0.26.0.mod", "Zip": "/Users/herby/go/pkg/mod/cache/download/cloud.google.com/go/@v/v0.26.0.zip", "Dir": "/Users/herby/go/pkg/mod/cloud.google.com/go@v0.26.0", "Sum": "h1:e0WKqKTd5BnrG8aKH3J3h+QvEIQtSUcf2n5UZ5ZgLtQ=", "GoModSum": "h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=" } { "Path": "github.com/BurntSushi/toml", "Version": "v0.3.1", "Info": "/Users/herby/go/pkg/mod/cache/download/github.com/!burnt!sushi/toml/@v/v0.3.1.info", "GoMod": "/Users/herby/go/pkg/mod/cache/download/github.com/!burnt!sushi/toml/@v/v0.3.1.mod", "Zip": "/Users/herby/go/pkg/mod/cache/download/github.com/!burnt!sushi/toml/@v/v0.3.1.zip", "Dir": "/Users/herby/go/pkg/mod/github.com/!burnt!sushi/toml@v0.3.1", "Sum": "h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=", "GoModSum": "h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=" } ...
comment:8 Changed 4 years ago by amake (Aaron Madlon-Kay)
Some background:
I made go2port
before the modern go module system existed, when there were several competing dependency managers (glide, gopkg, glock); it's modeled after other portfile generators like pypi2port
and cpan2port
. I made the golang-1.0 portgroup largely based on other portgroup idioms and the peco portfile.
I am not a golang guy. I just wanted to make and maintain ports for tools that happened to be in golang. go2port
was my first (and last, so far) golang project. So it sounds like you have a much better understanding of the ecosystem than I do.
There is no mandate to use either go2port
or the golang-1.0 portgroup. If you have better ideas that better meet MacPorts requirements then by all means we should move on.
The go mod download -json
output sounds very useful, but I'm not seeing a way to use that *within* a portfile that lets MacPorts manage the fetching (which is what we're really concerned with here). The best I can imagine is using it to generate the distfiles and checksums sections, but that's basically what go2port
already does.
comment:9 Changed 4 years ago by amake (Aaron Madlon-Kay)
I should add: In the pre-go-module-system world, there was no danger of dependencies being automatically downloaded, because all projects (as far as I know) either committed their dependencies or used a third-party tool like glide, et al. It's only recently that this has become a problem.
comment:10 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:11 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:12 Changed 4 years ago by mf2k (Frank Schima)
Cc: | breun cardi dgsb eborisch harens herbygillot i0ntempest l2dy lbschenkel mjrc nickolaev sirn added; @… @… @… @… @… @… @… @… @… @… @… @… removed |
---|
comment:13 follow-up: 14 Changed 4 years ago by i0ntempest
What's the best way of getting the names/urls of all the dependencies used by Go? Once I know that I'll try fixing gotop.
comment:14 Changed 4 years ago by amake (Aaron Madlon-Kay)
Replying to i0ntempest:
What's the best way of getting the names/urls of all the dependencies used by Go? Once I know that I'll try fixing gotop.
Currently it's to use go2port. When it works well it's good, but there are often little stumbling blocks. See the "fixed" links in the table for details.
comment:15 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:16 Changed 4 years ago by i0ntempest
So gotop needs to fetch stuff from howett.net/plist which go.vendors
doesn't support. Alternative is https://github.com/DHowett/go-plist, that fetches it to ${gopath}/src/github.com/DHowett/go-plist
, then I'll need to link it to ${gopath}/src/howett.net/plist
, only then it will build. Don't know if there's a better way but it works.
PR: https://github.com/macports/macports-ports/pull/8486
comment:17 Changed 4 years ago by breun (Nils Breunese)
I created and maintain the k9s and kustomize ports, because I needed those tools, but I am not very familiar with Go and I’m not really sure what I need to do. If anyone could outline the process that would be helpful. Or maybe someone can even create pull requests for these ports?
comment:18 Changed 4 years ago by Aaron Madlon-Kay <amake@…>
comment:19 Changed 4 years ago by i0ntempest
Run go2port
on your software repo and it will output a portfile. You take the checksum block and the go.vendors
block and put them into your portfile (replace the old checksum block), add GOPROXY=off
and GO111MODULE=off
to build.env
, and see if it works. You'll most likely need to do a bit of additional fixing and tweaking.
comment:20 Changed 4 years ago by Aaron Madlon-Kay <amake@…>
comment:21 Changed 4 years ago by i0ntempest
comment:22 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:23 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:24 Changed 4 years ago by Aaron Madlon-Kay <aaron@…>
comment:25 Changed 4 years ago by Aaron Madlon-Kay <aaron@…>
comment:26 Changed 4 years ago by Aaron Madlon-Kay <aaron@…>
comment:27 Changed 4 years ago by Aaron Madlon-Kay <aaron@…>
comment:28 Changed 4 years ago by herbygillot (Herby Gillot)
comment:29 follow-up: 31 Changed 4 years ago by herbygillot (Herby Gillot)
Seeing another issue where things fail when go.vendors
contains:
- two modules of the same name even though they live in different repos
- or two or more versions of the exact same module (main project may require vX, but a dependency uses vY)
comment:30 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:31 Changed 4 years ago by amake (Aaron Madlon-Kay)
Replying to herbygillot:
Seeing another issue where things fail when
go.vendors
contains:
- two modules of the same name even though they live in different repos
- or two or more versions of the exact same module (main project may require vX, but a dependency uses vY)
I fixed one limitation relating to this recently in https://github.com/macports/macports-ports/commit/3ad6f3ce0a0c011466bbd3e076295879f1148975, but there are still limitations relating to how GitHub names tarballs: tarballs fetched from a tag ref have the tag's hash in the name, so to identify the extracted directory you must either
- Specify the hash in addition to the tag (cumbersome), or
- Only use the hash and never a tag (also cumbersome, harder to understand)
The workaround currently used by both golang-1.0 and github-1.0 portgroups is to use globs (${author}-${project}-*
). This works for 99% of cases but obviously fails in the case of multiple tarballs from the same repo.
comment:32 follow-up: 33 Changed 4 years ago by breun (Nils Breunese)
I tried using go2port
for the k9s
port and I got a Portfile with really long list of go.vendors
. I then added the other metadata, like description
, license
, etc. from the current k9s Portfile
.
However, when I run portindex
I get this error:
Error: go.vendors can't handle dependencies from k8s.io Failed to parse file sysutils/k9s/Portfile: can't set "go.vendors": invalid command name "unsupported dependency domain"
All entries with github.com URLs in go.vendors
look fine, but the ones for k8s.io, sigs.k8s.io, google.golang.org, go.uber.org, helm.sh, go.opencensus.io, rsc.io, vbom.ml all have rmd160
, sha256
and size
set to 0
. It seems that these domains are not supported by go.vendors
. Is there a way around this?
comment:33 Changed 4 years ago by amake (Aaron Madlon-Kay)
Replying to breun:
All entries with github.com URLs in
go.vendors
look fine, but the ones for k8s.io, sigs.k8s.io, google.golang.org, go.uber.org, helm.sh, go.opencensus.io, rsc.io, vbom.ml all havermd160
,sha256
andsize
set to0
. It seems that these domains are not supported bygo.vendors
. Is there a way around this?
Those domains are indeed not supported by go.vendors
. Golang allows arbitrary domains in package identifiers; often those domains simply redirect to well-known hosts like GitHub, but at the moment we don't have a way to figure that out.
The only way to handle this right now would be
- Manually resolve those package IDs
- If the actual host is a known one like GitHub, then replace the package ID with the GitHub, etc., equivalent
- In the post-extract phase, move the extracted directory to its correct place in the GOPATH according to its original package ID
If the package resolves to a host that is not understood by the golang-1.0 portgroup, then you would have to set up the distfile manually the usual way with distfiles
and master_sites
.
I have an idea for an improvement. I will ping you with more later.
comment:34 Changed 4 years ago by amake (Aaron Madlon-Kay)
I've updated both go2port
and the golang-1.0 portgroup to support auto-resolving custom domains (thanks to @mohd-akram). With this, a lot of the dependencies for k9s will be handled nicely automatically. However some will not:
- Any deps "deeper" than the top level (like
github.com/Azure/go-autorest/autorest/adal
) don't work right. The root is also a dependency so you can delete those. google.golang.org/protobuf
is hosted atgo.googlesource.com
; tarballs from here are not deterministic. You can manually replace it withgithub.com/protocolbuffers/protobuf-go
- The Microsoft dependencies reference
github.com/Microsoft
, but this has been renamed togithub.com/microsoft
. This needs to be manually resolved.
Unfortunately after fixing all of that, I got build errors like:
# github.com/deislabs/oras/pkg/content ../../deislabs/oras/pkg/content/file.go:23:2: cannot use &FileStore literal (type *FileStore) as type ProvideIngester in assignment: *FileStore does not implement ProvideIngester (wrong type for ReaderAt method) have ReaderAt(context.Context, "github.com/opencontainers/image-spec/specs-go/v1".Descriptor) (content.ReaderAt, error) want ReaderAt(context.Context, "github.com/containerd/containerd/vendor/github.com/opencontainers/image-spec/specs-go/v1".Descriptor) (content.ReaderAt, error)
The errors seem to have something to do with incorrectly resolving full type names in the GOPATH. I don't know enough about go to fix it.
I'll attach the complete portfile in case it helps.
Changed 4 years ago by amake (Aaron Madlon-Kay)
k9s portfile with go.vendors
comment:35 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:36 Changed 4 years ago by mohd-akram (Mohamed Akram)
I'm also having an issue updating caddy because of two similarly named packages (qtls and qtls-go1-15). I think fetching from /archive/
instead of /tarball/
on GitHub can fix this issue since it uses more sane naming. Perhaps there could be an option akin to github.tarball_from
to not break existing ports. In the meantime, filtering the globbed list via regex could help too.
comment:37 Changed 4 years ago by herbygillot (Herby Gillot)
comment:38 Changed 4 years ago by herbygillot (Herby Gillot)
comment:39 Changed 4 years ago by herbygillot (Herby Gillot)
comment:40 Changed 4 years ago by harens (Haren S)
comment:41 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:42 Changed 4 years ago by amake (Aaron Madlon-Kay)
I tried to go.vendor
ize the kubergrunt
port and ran into basically the same issues described above. I'll attach the portfile just in case someone figures out how to fix it.
Changed 4 years ago by amake (Aaron Madlon-Kay)
Attachment: | Portfile.2 added |
---|
kubergrunt portfile with go.vendors
comment:43 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:44 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:45 Changed 4 years ago by amake (Aaron Madlon-Kay)
Similar import issue for golangci-lint
as with kubergrunt
and k9s
.
Changed 4 years ago by amake (Aaron Madlon-Kay)
Attachment: | Portfile.3 added |
---|
golangci-lint portfile with go.vendors
comment:46 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:47 Changed 4 years ago by i0ntempest
Cc: | i0ntempest removed |
---|
comment:48 Changed 4 years ago by Aaron Madlon-Kay <amake@…>
comment:49 Changed 4 years ago by Aaron Madlon-Kay <aaron@…>
comment:50 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:51 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:52 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:53 follow-up: 55 Changed 4 years ago by breun (Nils Breunese)
I should add: In the pre-go-module-system world, there was no danger of dependencies being automatically downloaded, because all projects (as far as I know) either committed their dependencies or used a third-party tool like glide, et al. It's only recently that this has become a problem.
I must admit I do not completely understand what the problem exactly is. I maintain a couple of Go ports, but I'm not very familiar with the Go ecosystem. I am however very familiar with the Java ecosystem and the Maven build tool specifically and I'm used to build tools downloading dependencies at build time (when not previously downloaded and locally cached). Maven uses Maven repositories to download dependencies, which support hashes and signatures, etc. Is the problem that Go builds download dependencies without any checks? If not, what is the problem exactly?
Changed 4 years ago by breun (Nils Breunese)
Attachment: | k9s-with-go.vendors-failure.txt added |
---|
comment:54 follow-up: 56 Changed 4 years ago by breun (Nils Breunese)
k9s portfile with go.vendors
Thanks for creating this. However, when I try to build this locally, it takes quite a long time and then fails to build with some Go build error that I don't understand. I attached k9s-with-go.vendors-failure.txt
to this ticket. Anyone know what's wrong here?
comment:55 Changed 4 years ago by amake (Aaron Madlon-Kay)
Replying to breun:
I must admit I do not completely understand what the problem exactly is.
There are two problems:
- Downloading dependencies outside of MacPorts' fetch mechanism prevents MacPorts from mirroring distfiles. That's bad for a number of reasons, such as: upstream could disappear, or we send a lot of traffic their way putting a strain on their infrastructure.
- Some build-time dependency fetching schemes lack a locking mechanism, so the exact version of the dependency used can differ depending on when exactly the build was performed. This is bad for reproducibility.
I am however very familiar with the Java ecosystem and the Maven build tool specifically and I'm used to build tools downloading dependencies at build time (when not previously downloaded and locally cached).
Sure, that's fine and good, but suboptimal for a MacPorts port.
Maven uses Maven repositories to download dependencies, which support hashes and signatures, etc. Is the problem that Go builds download dependencies without any checks? If not, what is the problem exactly?
No, Maven is also problematic for (1) above. For (2), Maven does allow version ranges but they are not used that often in my experience, so that's good. But in my experience it also doesn't provide a lockfile-like mechanism that would ensure that dependencies can't be silently replaced upstream.
Are there ports building with Maven that are downloading their dependencies at build time? If so, I guess the main reason they have been given a pass in the past is, as I understand it:
- Until recently there was no Java port, and Java could not be assumed to be available, so we basically didn't build any Java ports from source; they have mostly been grabbing pre-compiled (JAR) distfiles
- No one was paying attention
comment:56 follow-up: 73 Changed 4 years ago by amake (Aaron Madlon-Kay)
Replying to breun:
k9s portfile with go.vendors
Thanks for creating this. However, when I try to build this locally, it takes quite a long time and then fails to build with some Go build error that I don't understand. I attached
k9s-with-go.vendors-failure.txt
to this ticket. Anyone know what's wrong here?
Yes, that's what I reported earlier.
I think the problem is that some of the dependencies have their own vendored dependencies (in a vendor
dir at the dependency's root), and when GO111MODULE=off
this is unexpected: instead it's expected that all packages should be flattened into the GOPATH.
I'm not sure what to do about it.
comment:57 Changed 4 years ago by Aaron Madlon-Kay <amake@…>
comment:58 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:59 Changed 4 years ago by dgsb (David Bariod)
I was wondering if it is wise to reimplement something that the go compiler already does. I think the go build problem may not be trivial to replicate in macports.
comment:60 Changed 4 years ago by Aaron Madlon-Kay <amake@…>
comment:61 Changed 4 years ago by Aaron Madlon-Kay <amake@…>
comment:62 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:63 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:64 Changed 4 years ago by Aaron Madlon-Kay <aaron@…>
comment:65 Changed 4 years ago by Aaron Madlon-Kay <aaron@…>
comment:66 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:67 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:68 Changed 4 years ago by Aaron Madlon-Kay <aaron@…>
comment:69 Changed 4 years ago by Aaron Madlon-Kay <aaron@…>
comment:70 Changed 4 years ago by Aaron Madlon-Kay <amake@…>
comment:71 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:72 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:73 Changed 4 years ago by breun (Nils Breunese)
Replying to amake:
I think the problem is that some of the dependencies have their own vendored dependencies (in a
vendor
dir at the dependency's root), and whenGO111MODULE=off
this is unexpected: instead it's expected that all packages should be flattened into the GOPATH.I'm not sure what to do about it.
Neither am I. I maintain these ports because I use these tools myself, but I am not familiar with how Go software gets built. I was already struggling quite a bit to get an initial Portfile for k9s
working, and it seems that this go.vendor
stuff adds a whole new dimension of complexity. Are there any people familiar enough with Go builds in this thread that could help out?
comment:74 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
comment:75 Changed 4 years ago by Aaron Madlon-Kay <amake@…>
comment:76 Changed 4 years ago by i0ntempest
I'm submitting cloudflared to macports (https://github.com/macports/macports-ports/pull/8662), it has two problematic dependencies. One is known to be unsolvable yet (multiple versions of the same dependency, go-oidc v1 and v2), another one seem to be a new problem (giving error: no files matched glob pattern "/opt/local/var/macports/build/_Users_Admin_Ports_net_cloudflared/cloudflared/work/kshvakov-clickhouse-*"
) However it builds and works anyway without these two dependencies. Please take a look if interested.
comment:77 Changed 4 years ago by i0ntempest
Cc: | i0ntempest added |
---|
comment:78 Changed 4 years ago by herbygillot (Herby Gillot)
tektoncd-cli
can be marked as fixed since it vendors all its dependencies already. It builds with GOPROXY=off
, which has been added as of version 0.13.0:
https://github.com/macports/macports-ports/commit/cc7c646f38bc9729fbf1763df76abdbdff9d3a03
comment:79 Changed 4 years ago by herbygillot (Herby Gillot)
comment:80 Changed 4 years ago by i0ntempest
Cc: | i0ntempest removed |
---|
comment:81 Changed 4 years ago by l2dy (Zero King)
Cc: | l2dy removed |
---|
comment:82 Changed 4 years ago by i0ntempest
Another problematic port: https://github.com/macports/macports-ports/pull/8721
comment:83 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|---|
Port: | nebula added |
comment:84 Changed 4 years ago by amake (Aaron Madlon-Kay)
Port: | qri added |
---|
comment:85 Changed 4 years ago by Aaron Madlon-Kay <amake@…>
comment:86 Changed 4 years ago by amake (Aaron Madlon-Kay)
Description: | modified (diff) |
---|
Herby, you may wish to know about this since you've been doing a lot of go-based ports.