gobject-introspection -- unfortunately recent fixes have broken it on several ports.... argh

[31n81t (Maigurs)]

Gimp build/install fails on Catalina 10.15.7 MacbookPro 15 mid 2012

sudo port install gimp
Password:
--->  Computing dependencies for gimp
The following dependencies will be installed: 
 OpenBLAS
 avahi
 cmake
 cython_select
 dbus-python38
 gegl
 gexiv2
 gimp-app
 gimp-help-en
 gimp-lqr-plugin
 gimp2
 gutenprint
 iso-codes
 json-c
 lcms
 libcxx
 libdaemon
 libgcc
 libgcc10
 libglade2
 liblqr
 libmng
 libmypaint
 libpcap
 libspiro
 libuv
 libwmf
 luajit
 mypaint-brushes1
 net-snmp
 nosetests_select
 nspr
 nss
 poly2tri-c
 poppler
 poppler-data
 py27-cython
 py27-gobject
 py27-nose
 py27-numpy
 py27-pygtk
 py27-setuptools
 py38-gdbm
 sane-backends
 xdg-utils
 xsane
Continue? [Y/n]: y
--->  Fetching archive for gexiv2
--->  Attempting to fetch gexiv2-0.12.1_0+python27+python38.darwin_19.x86_64.tbz2 from https://packages.macports.org/gexiv2
--->  Attempting to fetch gexiv2-0.12.1_0+python27+python38.darwin_19.x86_64.tbz2 from https://mse.uk.packages.macports.org/gexiv2
--->  Attempting to fetch gexiv2-0.12.1_0+python27+python38.darwin_19.x86_64.tbz2 from https://lil.fr.packages.macports.org/gexiv2
--->  Building gexiv2
Error: Failed to build gexiv2: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_gexiv2/gexiv2/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port gimp failed

[31n81t (Maigurs)]

build log

[mf2k (Frank Schima)]

Error appears to be:

:info:build g-ir-scanner: link: /usr/bin/clang -arch x86_64 -o /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_gexiv2/gexiv2/work/build/tmp-introspect93c7jzva/GExiv2-0.10 /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_gexiv2/gexiv2/work/build/tmp-introspect93c7jzva/GExiv2-0.10.o -L. -Wl,-rpath,. -L/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_gexiv2/gexiv2/work/build/gexiv2 -Wl,-rpath,/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_gexiv2/gexiv2/work/build/gexiv2 -L/opt/local/lib -Wl,-rpath,/opt/local/lib -L/opt/local/lib -Wl,-rpath,/opt/local/lib -L/opt/local/lib -Wl,-rpath,/opt/local/lib -lgexiv2 -lgobject-2.0 -lglib-2.0 -lintl -lexiv2 -lgio-2.0 -lgirepository-1.0 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lintl -Wl,-framework -Wl,CoreFoundation
:info:build dyld: Symbol not found: _iconv
:info:build   Referenced from: /usr/lib/libarchive.2.dylib
:info:build   Expected in: /opt/local/lib/libiconv.2.dylib
:info:build  in /usr/lib/libarchive.2.dylib

[kencu (Ken)]

Yuk. Picking up the wrong libiconv now....

hopefully not caused by: [e6d093a57f6a86b0ace628ff70d6ec79fd3808ee/macports-ports]

[kencu (Ken)]

I can't build this either. Similar error.

dyld: Symbol not found: _iconv
  Referenced from: /usr/lib/libmecab.1.0.0.dylib
  Expected in: /opt/local/lib/libiconv.2.dylib
 in /usr/lib/libmecab.1.0.0.dylib

[kencu (Ken)]

Michael -- if you get a moment, please see if you can try to build this.

It builds fine before the commit to gobject-introspection but won't build after that commit. Must be something to do with DYLD_LIBRARY_PATH but it's not easy to see the enviroment settings when g-ir-scanner runs.

[kencu (Ken)]

libsoup is broken too:

dyld: Symbol not found: _iconv
  Referenced from: /usr/lib/libmecab.1.0.0.dylib
  Expected in: /opt/local/lib/libiconv.2.dylib
 in /usr/lib/libmecab.1.0.0.dylib

[michaelld (Michael Dickens)]

Arg. Thanks for the prod, @kencu. Let me start building locally & see what I can work out ...

[michaelld (Michael Dickens)]

I see this too on py*-gobject3 ... probably others. After some testing, I think I have a solution that's robust. The issue keeps being that -L${prefix}/lib is appearing in the link commands! PR coming shortly for testing. Works for me on 10.15 Xcode 12 for both py38-gobject3 as well as gexiv2.

[michaelld (Michael Dickens)]

Please test this PR: ​https://github.com/macports/macports-ports/pull/8985

[michaelld (Michael Dickens)]

In 8fb49743e47074c890d88f03de4528857b495dcb/macports-ports (master):

gobject-introspection: tweak scanner patch

Now handles build-provided library paths more robustly, removing those that are found via PKGCONFIG and are thus clearly "system" paths.

Ref: #61382

[michaelld (Michael Dickens)]

I'm going to go ahead and close this ticket as "fixed". Since testing by me and others shows that the tweaks added do indeed fix this and all known related build issues when using our modified GO-I. Please reopen if you still have issues & post a new build log along with the port(s) showing issues.

[kencu (Ken)]

Well done, Michael -- thanks.

[31n81t (Maigurs)]

Gimp by itself builds and installs but when I launch it it appears on dock for short time and disappears (other words does nothing). When I launch Gimp from terminal I got message Cannot open display:

Btw thanks for quick response! Thank you.

Regards

[jmroot (Joshua Root)]

Please open a new ticket for the new issue.