audio/pianod 343 update from upstream

[perette (Perette Barella)]

Update port from version 175 to 343, reflecting the latest upstream version.

[ryandesign (Ryan Carsten Schmidt)]

-version             175
-revision            3
+version             329

A revision 0 line should remain here.

+distfiles           pianod2-${version}.tar.gz

This should instead be distname piano2-${version}.

+checksums           rmd160  7c8eb6c4ee38d6e2cd2a1a0232457e2638f0b8c9 \
+                    sha256  48f2409a0c033fc92ac90e2e4beafc736b119cdcd7532ab140f3cb32da5f7e68

size should be added as a third checksum type.

+platform darwin 8 {
+depends_lib         port:curl port:taglib port:ffmpeg port:libao
+}
+
+platform darwin 9 {
+depends_lib         port:curl port:taglib port:ffmpeg port:libao
+}

Why are ffmpeg and libao only used on Darwin 8 and 9?

To avoid duplicating code, these two blocks should be combined into one.

You should append to your existing depends_lib rather than overwriting it.

[perette (Perette Barella)]

patchfile for pianod portfile, 175 to 329, revised with requests per Ryan

[perette (Perette Barella)]

Why are ffmpeg and libao only used on Darwin 8 and 9?

These are needed for Snow Leopard (darwin 10) and earlier. AVFoundation, introduced in Lion, is used in later releases.

[ryandesign (Ryan Carsten Schmidt)]

I tried installing the port on macOS 10.13 and it ends up linking with a lot more things than you declared dependencies on:

$ otool -L /opt/local/bin/pianod
/opt/local/bin/pianod:
	/opt/local/lib/libtag.1.dylib (compatibility version 1.0.0, current version 1.17.0)
	/opt/local/lib/libgstreamer-1.0.0.dylib (compatibility version 1603.0.0, current version 1603.0.0)
	/opt/local/lib/libgobject-2.0.0.dylib (compatibility version 5801.0.0, current version 5801.3.0)
	/opt/local/lib/libglib-2.0.0.dylib (compatibility version 5801.0.0, current version 5801.3.0)
	/opt/local/lib/libintl.8.dylib (compatibility version 10.0.0, current version 10.7.0)
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1455.255.0)
	/opt/local/lib/libgnutls.30.dylib (compatibility version 59.0.0, current version 59.1.0)
	/usr/lib/libpam.2.dylib (compatibility version 3.0.0, current version 3.0.0)
	/opt/local/lib/libcurl.4.dylib (compatibility version 12.0.0, current version 12.0.0)
	/opt/local/lib/libwrap.7.dylib (compatibility version 7.0.0, current version 7.6.0)
	/opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.50.4)

[perette (Perette Barella)]

configure assesses what is installed and chooses audio support and other features based on that. Should the Portfile be forcing its choices?

[ryandesign (Ryan Carsten Schmidt)]

Port builds must be deterministic. You removed the gnutls dependency, but I already had gnutls installed and the port linked with gnutls. The port must therefore either declare a dependency on gnutls or ensure that gnutls will not be used even if it is already installed. Same for all of the other libraries.

[perette (Perette Barella)]

I tried setting up the Portfile to run configure with various options to get it to build a certain way. It didn't work, and given limited time in my life, I recognize this isn't a technology battle I'm interested in winning.

Given the age of the existing port, and software rot issues (changing keys on Pandora and such) that I think mean it's broken as installed, I recommend the removal of this port. Is it possible to do that?

[perette (Perette Barella)]

Revised patch 175->329 providing configure options to ensure no unexpected linking.

[perette (Perette Barella)]

Further revised patch to straight from 175 to 343.