Opened 4 years ago
Last modified 2 years ago
#62011 assigned enhancement
opencv/opencv4: eliminate portfile duplication, via subport — at Version 6
Reported by: | mascguy (Christopher Nielsen) | Owned by: | mascguy (Christopher Nielsen) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | ||
Port: | opencv3 opencv4 |
Description (last modified by mascguy (Christopher Nielsen))
Now that the two OpenCV-related ports have been brought up to parity, there are very few differences between them. Eliminate the portfile duplication, via subports.
Also add the following variants, which I missed when bringing both up to parity:
- opencv:
openmp
- opencv4:
openni
Other notable cleanup that will be tackled during the reconciliation:
- Universal use of
github
portgroup. Currently used for opencv4, but not for opencv/opencv3. - Fully implement variant
openmp
, which is effectively a stub at this point. (While OpenMP is being enabled via configure flag,compiler.openmp_version
isn't being set. With the result being that OpenMP isn't found, effectively making this variant a no-op at the moment.)
There is additional cleanup as well, but that covers the most notable items.
Change History (6)
comment:1 Changed 4 years ago by mascguy (Christopher Nielsen)
Description: | modified (diff) |
---|
comment:2 Changed 4 years ago by mascguy (Christopher Nielsen)
Description: | modified (diff) |
---|
comment:3 Changed 4 years ago by mascguy (Christopher Nielsen)
comment:4 Changed 4 years ago by mascguy (Christopher Nielsen)
PRs submitted for first two phases:
comment:5 Changed 4 years ago by Christopher Nielsen <mascguy@…>
comment:6 Changed 4 years ago by mascguy (Christopher Nielsen)
Description: | modified (diff) |
---|
Note: See
TracTickets for help on using
tickets.
This will be done in phases, coordinated with reinstatement of OpenCV 2 port (issue:49670):
opencv3
, segregated like opencv4. Also include initial changes, supporting later conversion to subport.opencv
, to useopencv3
. And update portopencv
to be a stub port, withreplaced_by opencv3
, etc.opencv2
, using same segregation strategy, etc.opencv
port, with three subports. This step may be combined with previous.Thoughts/feedback welcome, as always.