Changes between Initial Version and Version 6 of Ticket #62642


Ignore:
Timestamp:
Apr 7, 2021, 5:33:27 AM (4 years ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

Now that this matter has been brought to our attention, yes, it seems reasonable that the portgroup should not add -DDEBUG by default. However, there are over 500 ports already using this portgroup. Who agrees to audit all of these ports to determine whether this change in the portgroup changes how those ports build with the +debug variant?

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #62642 – Description

    initial v6  
    55I suggest simply not using `-DDEBUG` by default. If a port needs it for its debug mode, it should include it explicitly, not the reverse (i.e. having to remove it explicitly).
    66
    7 This behaviour was originally added here: https://github.com/macports/macports-ports/commit/e8f9c3dbe31f1b604b076a8753b3ea26d265e276
     7This behaviour was originally added here: [e8f9c3dbe31f1b604b076a8753b3ea26d265e276/macports-ports]