Changes between Version 5 and Version 6 of Ticket #63455, comment 14


Ignore:
Timestamp:
Jan 1, 2022, 2:23:25 AM (3 years ago)
Author:
kencu (Ken)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #63455, comment 14

    v5 v6  
    22> To avoid confusion, I proposed cleaning up the “allow newer libtool” patching: [https://github.com/macports/macports-ports/pull/13541]
    33
    4 There are many thousands of ports that build calling "{{{libtool}}}". About the only port that specifically forces {{{/usr/bin/libtool}}} is {{{mysql*}}}, which it should never have done.
     4There are many ports that build calling "{{{libtool}}}". About the only port that specifically forces {{{/usr/bin/libtool}}} is {{{mysql*}}}, which it should never have done.
    55
    6 There is no possibly way that the {{{mysql*}}} dev team could know which libtool is the proper one to use on darwin. By doing this forcing, they were already breaking a bunch of builds.
    7 
    8 So you might best revert your cleanup and put it back the way I fixed it, so that {{{/usr/bin/libtool}}} is not inappropriately forced.
    9 
     6So you might best revert your cleanup and put it back so that {{{/usr/bin/libtool}}} is not inappropriately forced.
    107
    118It should be upstreamed to get them to take out {{{/usr/bin/libtool}}} and just use {{{libtool}}}.
    129
    13 There is no need to specifically patch mysql to use {{{${prefix}/bin/libtool}}}, as our proper mechanisms will work, and the other 10,000 ports that use libtool are not so patched. It won't break anything, at least not immediately, but it is, in it's own way, as wrong as mysql forcing {{{/usr/bin/libtool}}}. Just use {{{libtool}}} and all will be well.
    14 
     10There is no need to specifically patch mysql to use {{{${prefix}/bin/libtool}}}, as our proper mechanisms will work.
    1511
    1612> because [122fca8e4617/macports-ports] was done without specifying cctools as a build dependency, meaning that using trace mode defeats the purpose of that change.
    1713
    18 That is not, in general, correct. All older systems that use macports-clang-* already have added a dep for cctools as part of the use of macports-clang=*, as you can see here:
     14All older systems that use macports-clang-* already have added a dep for cctools as part of the use of macports-clang=*, as you can see here:
    1915
    2016https://ports.macports.org/port/clang-9.0/details/
    … …  
    2218so the purpose of the change was not defeated in general. But the use {{{cctools}}} version of {{{libtool}}} may now need to be extended to more systems.
    2319
    24 
    25 > Similar patching is still done in e.g. mysql56 and mariadb; should those instead add cctools build dependency and patch to use `${prefix}/bin/libtool` on older systems?
    26 
    27 No, this is not needed, see above, the dep to cctools is already added by the macports-clang-* ports.
    28 
    29 
    3020What you may (or may not, we wait to see) have found here in this ticket appears to be that on some newer versions of macos (that are not presently using a macports-clang compiler to build mysql)  the {{{/usr/bin/libtool}}} fails when building mysql, but the libtool provided by cctools at {{{${prefix}/bin/libtool}}} does build it.
    3121