Opened 3 years ago

Last modified 3 years ago

#64396 closed update

[samba4] use of undeclared identifier 'O_CLOEXEC' in tdb_wrap.c — at Version 7

Reported by: BjarneDMat Owned by:
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: evanmiller (Evan Miller)
Port: samba4

Description (last modified by BjarneDMat)

[1052/3660] Compiling lib/tdb_wrap/tdb_wrap.c
../../lib/tdb_wrap/tdb_wrap.c:107:16: error: use of undeclared identifier 'O_CLOEXEC'
        open_flags |= O_CLOEXEC;
                      ^

Ok - this is with an updated Portfile

Change History (11)

Changed 3 years ago by BjarneDMat

Attachment: patch-no-xsltproc.diff added

fixed offsets

comment:1 Changed 3 years ago by BjarneDMat

I'm trying to install samba4 on 10.6.8 in order to get it compatible w/ 11.x & 12.x as afp is removed from those & one will have to use smb

so, the samba4 portfile is outdated & fails to compile, so I thought I'ld try to update it.

My 1st problem is :

:notice:fetch --->  Attempting to fetch samba-4.15.3.tar.gz from https://download.samba.org/pub/samba/stable
:debug:fetch Fetching distfile failed: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

How do I fix this ?

for now, I'll do a manual download :

curl --url \
  "https://download.samba.org/pub/samba/stable/{samba-4.15.3.tar.gz}" \
  --create-dirs \
  -o /opt/local/var/macports/distfiles/samba4/#1

comment:2 Changed 3 years ago by BjarneDMat

Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_samba4/samba4/work/samba-4.15.3" && /usr/bin/patch -p1 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/net/samba4/files/patch-fix-debug.diff'
DEBUG: system:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_samba4/samba4/work/samba-4.15.3" && /usr/bin/patch -p1 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/net/samba4/files/patch-fix-debug.diff'
patching file lib/util/charset/charset_macosxfs.c
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file lib/util/charset/charset_macosxfs.c.rej
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_samba4/samba4/work/samba-4.15.3" && /usr/bin/patch -p1 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/net/samba4/files/patch-fix-debug.diff'
Exit code: 1
Error: Failed to patch samba4: command execution failed

But applying manually :

root@MiniWeb 02:45:55 /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_samba4/samba4/work/samba-4.15.3
#=> /usr/bin/patch -p1 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/net/samba4/files/patch-fix-debug.diff' patching file lib/util/charset/charset_macosxfs.c
Reversed (or previously applied) patch detected!  Assume -R? [n] y

and success !?!

Changed 3 years ago by BjarneDMat

Attachment: main.log added

comment:3 in reply to:  2 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to BjarneDMat:

My 1st problem is :

:notice:fetch --->  Attempting to fetch samba-4.15.3.tar.gz from https://download.samba.org/pub/samba/stable
:debug:fetch Fetching distfile failed: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

How do I fix this ?

Read ProblemHotlist#letsencrypt.

Replying to BjarneDMat:

Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_samba4/samba4/work/samba-4.15.3" && /usr/bin/patch -p1 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/net/samba4/files/patch-fix-debug.diff'
DEBUG: system:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_samba4/samba4/work/samba-4.15.3" && /usr/bin/patch -p1 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/net/samba4/files/patch-fix-debug.diff'
patching file lib/util/charset/charset_macosxfs.c
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file lib/util/charset/charset_macosxfs.c.rej
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_samba4/samba4/work/samba-4.15.3" && /usr/bin/patch -p1 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/net/samba4/files/patch-fix-debug.diff'
Exit code: 1
Error: Failed to patch samba4: command execution failed

But applying manually :

root@MiniWeb 02:45:55 /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_samba4/samba4/work/samba-4.15.3
#=> /usr/bin/patch -p1 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/net/samba4/files/patch-fix-debug.diff' patching file lib/util/charset/charset_macosxfs.c
Reversed (or previously applied) patch detected!  Assume -R? [n] y

and success !?!

Based on the name of the patchfile, it fixed some debug problem. It failed to apply, perhaps because upstream integrated it into their sources. You answered "y" to the question of whether to apply the patch in reverse order, thereby undoing whatever the patch was fixing. So try again after removing this patch.

comment:4 Changed 3 years ago by evanmiller (Evan Miller)

Cc: evanmiller added

comment:5 Changed 3 years ago by BjarneDMat

Replying to ryandesign:

My 1st problem is :

:notice:fetch --->  Attempting to fetch samba-4.15.3.tar.gz from https://download.samba.org/pub/samba/stable
:debug:fetch Fetching distfile failed: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

How do I fix this ?
Read ProblemHotlist#letsencrypt.

That didn't fix the problem [thumbs-down]

I've followed the procedure exactly
& even done a reboot
& re-installed Macports 2.7.1

So, I pushed the Apple curl aside :

root@MiniWeb 17:17:26 /usr/bin
  506  mv curl curl.apple
  507  mv curl-config curl-config.apple
  508  ln -h $(which curl) .
  509  ln -h $(which curl-config) .
root@MiniWeb 17:54:33 /usr/bin
#=> ls -l cur*
-rwxr-xr-x  2 root  admin  238972 12 Nov 19:00 curl
-rwxr-xr-x  2 root  admin    6321 12 Nov 19:00 curl-config
-rwxr-xr-x  1 root  wheel    3835 25 Jun  2010 curl-config.apple
-rwxr-xr-x  1 root  wheel  369584 21 Mar  2012 curl.apple

& re-installed Macports 2.7.1
& I'm still getting the exact same error

#=>  /usr/bin/curl.apple 
    --url    "https://download.samba.org/pub/samba/stable/{samba-4.15.3.tar.gz}"
    --create-dirs
    -o /opt/local/var/macports/distfiles/samba4/#1
curl: (35) error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

Changed 3 years ago by BjarneDMat

Attachment: KeyRing.png added

Changed 3 years ago by BjarneDMat

Attachment: Buildbot.png added

comment:6 Changed 3 years ago by BjarneDMat

Original trac issue :

 [ 761/3660] Linking bin/default/lib/util/libsamba-util.dylib
 Undefined symbols for architecture x86_64:
   "_DEBUG", referenced from:
       _macosxfs_encoding_pull in charset_macosxfs.c.1.o
       _macosxfs_encoding_push in charset_macosxfs.c.1.o
 ld: symbol(s) not found for architecture x86_64

removing the patch-fix-debug.diff fixed the original issue [thumbs-up]

comment:7 Changed 3 years ago by BjarneDMat

Description: modified (diff)
Summary: [samba4] Undefined symbols for architecture x86_64 in charset_macosxfs.c.1.o[samba4] use of undeclared identifier 'O_CLOEXEC' in tdb_wrap.c
Note: See TracTickets for help on using tickets.