Opened 3 years ago
Closed 17 months ago
#64613 closed submission (fixed)
Variant of port "ClamAV" to support old systems
| Reported by: | ballapete (Peter "Pete" Dyballa) | Owned by: | barracuda156 |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.7.1 |
| Keywords: | tiger, leopard, snowleopard | Cc: | |
| Port: | clamav-legacy |
Description
I seem to be the only user of ClamAV on PPC Tiger and Leopard. Daniel Luke has no old hardware and systems, so Ken Cunningham supposed that I create a Portfile for a legacy version of ClamAV. This is it.
ClamAV .104 comes with a test suite that fails when no version of ClamAV is already installed. This is documented in #64021 and in https://github.com/Cisco-Talos/clamav/issues/449. In the tests section a few tries to overcome the problem are recorded.
CMAKE_BUILD_WITH_INSTALL_RPATH or CMAKE_MACOSX_RPATH certainly play no role on Tiger, possibly also on Leopard. Snow Leopard seems to have learned about RPATH. This could be adjusted for the next release – either a clause for this or validity of this port only for Tiger and Leopard.
The milter component is not useful – who will set up an eMail server on Tiger…Snow Leopard?
Setting the CXX standard seems to be appropriate and lets port simply choose appropriate compilers.
Tiger needs an extra patch, as documented in #64021.
It's possible that libtool is never used. I do not understand CMake enough to judge exactly.
This port built, without the hopefully rejecting clause, on Big Sur (12.1), High Sierra and PPC Tiger and Leopard.
I have a PowerBook G4 with Tiger and Leopard and a MacBook Pro, "MacBookPro8,3", that could be prepared to also run Snow Leopard, Lion, Mountain Lion, Mavericks, Yosemite, El Capitan, and Sierra (High Sierra is recently installed)! Could be I can find an intel PowerBook on eBay.
Attachments (1)
Change History (6)
comment:2 Changed 3 years ago by kencu (Ken)
So, Pete, time for your Pull Request and let's get this port off the ground.
comment:3 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)
rpath support appeared in Mac OS X 10.5 Leopard.
The maintainers line is not valid.
Line 97 (the one beginning with hub.com) is a syntax error.
Lines 112-129 (which define the python variants and which one of them is the default) are invalid because they occur within the tests variant; MacPorts has already finished determining the list of variants and defaults by the time that any variant's code is evaluated.
If you're going to have python variants, the default at this time should be python310.
The Portfile uses old Macintosh (carriage return) line endings. It must use UNIX (line feed) line endings.
-V should not be tacked on to test.cmd; it should be in test.args.
The port overrides the build dependencies the portgroups set. Use depends_build-append instead of depends_build.
Livecheck isn't using https though homepage and master_sites are. This should be made consistent, ideally by reusing existing variables rather than defining the same URL 2 and 3 times. This problem already existed in the original clamav portfile.
Changed 3 years ago by ballapete (Peter "Pete" Dyballa)
Corected version of Portfile
comment:4 Changed 3 years ago by ballapete (Peter "Pete" Dyballa)
An updated version of Portfile has been submitted.
comment:5 Changed 17 months ago by barracuda156
| Owner: | set to barracuda156 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Just so you know, and to make things terribly unclear,
CMAKE_BUILD_WITH_INSTALL_RPATHhas nothing to do with@rpathat all.CMAKE_BUILD_WITH_INSTALL_RPATHtells cmake whether to use the final installed libnames during the build, or whether to use temporary names (to their locations during the build) and then rewrite these names when destrooting happens to their final installed names.