Volk 2.5.1 Broken on <= 10.14, needs std::filesystem

[michaelld (Michael Dickens)]

I totally messed up the Volk 2.5.1 update commit ... will fix ASAP! Fixed that but then Volk 2.5 requires C++17 std::filesystem so need to deal with that now!

[ra1nb0w]

maybe, doing a revert.

[michaelld (Michael Dickens)]

I'll be working on this issue today. Major difficulty today is time (so many meetings) rather than the actual issue(s) ... but I'll get it done one way or the other!

[michaelld (Michael Dickens)]

In 415d0cc2bc47ea704dfb678fb1fa9475f1d3ad73/macports-ports (master):

volk: fix 2.5.1 build

Closes: #65377

[ra1nb0w]

macOS =< 10.14 don't have c++17 filesystem api

Run Build Command(s):/usr/bin/make -f Makefile cmTC_72415/fast && /Library/Developer/CommandLineTools/usr/bin/make  -f CMakeFiles/cmTC_72415.dir/build.make CMakeFiles/cmTC_72415.dir/build
Building CXX object CMakeFiles/cmTC_72415.dir/CheckIncludeFile.cxx.o
/usr/bin/clang++   -pipe -I/opt/local/libexec/boost/1.76/include -Os -DNDEBUG -I/opt/local/libexec/boost/1.76/include -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk -Wall  -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk -mmacosx-version-min=10.14 -std=gnu++17 -MD -MT CMakeFiles/cmTC_72415.dir/CheckIncludeFile.cxx.o -MF CMakeFiles/cmTC_72415.dir/CheckIncludeFile.cxx.o.d -o CMakeFiles/cmTC_72415.dir/CheckIncludeFile.cxx.o -c /opt/local/var/macports/build/_Users_rainbow_sources_github_macports-ports_science_volk/volk/work/build/CMakeFiles/CMakeTmp/CheckIncludeFile.cxx
/opt/local/var/macports/build/_Users_rainbow_sources_github_macports-ports_science_volk/volk/work/build/CMakeFiles/CMakeTmp/CheckIncludeFile.cxx:1:10: fatal error: 'filesystem' file not found
#include <filesystem>
         ^~~~~~~~~~~~
1 error generated.

Therefore it doesn't configure anymore.

Log ​https://build.macports.org/builders/ports-10.14_x86_64-builder/builds/131525/steps/install-port/logs/stdio

[ra1nb0w]

Note from version 2.5.1

In the past, we relied on Boost for several tasks in volk_profile. For years, we minimized Boost usage to boost::filesystem. We mostly switched to C++17 std::filesystem years ago. The last distribution in our CI system that required Boost to build VOLK, was Ubuntu 14.04. Thus, now is the time to remove the Boost dependency completely and rely on C++17 features.

[michaelld (Michael Dickens)]

Well crap