Opened 2 years ago

Last modified 2 years ago

#65405 closed enhancement

Frotz @2.5.3: Add option for sound and sdl interface — at Version 3

Reported by: mbrethen Owned by:
Priority: Normal Milestone:
Component: ports Version: 2.7.2
Keywords: haspatch Cc:
Port: frotz

Description (last modified by mbrethen)

Attached Portfile.diff adds variants "snd" and "sdl" and also archives docs in ${prefix}/share/doc/${name}. Note: the Makefile.diff has also been updated to remove a hardcoded ${prefix}.

Change History (6)

Changed 2 years ago by mbrethen

Attachment: patch-Makefile​ added

patch Makefile to use ${prefix} instead of hardcoded path

comment:1 Changed 2 years ago by ryandesign (Ryan Carsten Schmidt)

Your patch also totally reformats the whitespace of the Portfile, making it difficult to see what functional changes you're proposing. Usually whitespace changes should be made in a separate commit from functional changes.

Changed 2 years ago by mbrethen

Attachment: Portfile.diff​ added

Portfile patch

comment:2 in reply to:  1 Changed 2 years ago by mbrethen

Replying to ryandesign:

Your patch also totally reformats the whitespace of the Portfile, making it difficult to see what functional changes you're proposing. Usually whitespace changes should be made in a separate commit from functional changes.

Re-uploaded diff--lmk if that's acceptable.

Changed 2 years ago by mbrethen

Attachment: Portfile​ added

comment:3 Changed 2 years ago by mbrethen

Description: modified (diff)
Note: See TracTickets for help on using tickets.