Opened 2 years ago

Closed 2 years ago

#65661 closed enhancement (fixed)

broot 1.14.2: disable xorg-libxcb dependency

Reported by: rdslw Owned by: herbygillot (Herby Gillot)
Priority: Normal Milestone:
Component: ports Version: 2.7.2
Keywords: Cc:
Port: broot

Description

As discussed with @herby: Please consider DISABLING "xorg-libxcb" dependency in broot port. This dependency is required only for clipboard which is still optional broot feature and I'm not sure if working well on macos at all. But the biggest problem is that it pulls in quite a bunch depencdencies only because of xorg-libxcb.

Prefered solution: remove one line from Portfile removing xorg-libxcb

Change History (4)

comment:1 Changed 2 years ago by herbygillot (Herby Gillot)

Resolution: fixed
Status: assignedclosed

In e066391aa5d52fb0510a4c132d71e1a9e92f238d/macports-ports (master):

broot: remove xorg-libxcb dependency

Fixes: #65661

comment:2 Changed 2 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: closedreopened

This doesn't fix the case where someone has xorg-libxcb installed already. The port will still use it and now have a hidden dependency on it. It's use must be disabled in the configured phase.

Version 1, edited 2 years ago by mf2k (Frank Schima) (previous) (next) (diff)

comment:3 Changed 2 years ago by herbygillot (Herby Gillot)

Rust projects do not have a configure stage. They are built via cargo, and the closest thing would be features, which can change dependencies at build time.

broot's default set of features do not invoke clipboard features:

https://github.com/Canop/broot/blob/e8a5f7687ac9efd30d549ce2dd1b83e452506215/Cargo.toml#L18

...which in turn should not pull in Xcb. We were not invoking the feature before, which could explain why @rdslw thought it wasn't working properly before.

Also, the broot packages built in the MacPorts buildbots should not be installing xorg libs, so the resultant packages shouldn't have any reference to libxcb.

I don't think there's any additional steps we can take here.

That said, we could probably reintroduce clipboard capabilities as a variant for this port, however.

comment:4 Changed 2 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: reopenedclosed

I made sure that I had xorg-libxcb installed and did a source rebuild of broot. xorg-libxcb did not appear in the otool -L output.

Note: See TracTickets for help on using tickets.