p5.34-tk-tablematrix fails to build on Ventura

[laughingtiger]

As part of MacPorts on 2018 mac mini install of xmltv the required install of p5.34-tk-tablematrix fails to build on Ventura. Log ending with…

make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_perl_p5-tk-tablematrix/p5.34-tk-tablematrix/work/Tk-TableMatrix-1.26'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_perl_p5-tk-tablematrix/p5.34-tk-tablematrix/work/Tk-TableMatrix-1.26" && /usr/bin/make -j12 -w all 
:info:build Exit code: 2
:error:build Failed to build p5.34-tk-tablematrix: command execution failed
:debug:build Error code: CHILDSTATUS 87644 2
:debug:build Backtrace: command execution failed
:debug:build     while executing
:debug:build "system {*}$notty {*}$callback {*}$nice $fullcmdstring"
:debug:build     invoked from within
:debug:build "command_exec -callback portprogress::target_progress_callback build"
:debug:build     (procedure "portbuild::build_main" line 8)
:debug:build     invoked from within
:debug:build "$procedure $targetname"

[ryandesign (Ryan Carsten Schmidt)]

The end of the log is not helpful. The log contains many errors, starting with:

/opt/local/lib/perl5/vendor_perl/5.34/darwin-thread-multi-2level/Tk/pTk/tk.t:16:7: error: type name requires a specifier or qualifier
VFUNC(Var,LangFindVar,V_LangFindVar,_ANSI_ARGS_((Tcl_Interp * interp, Tk_Window, CONST char *name)))
      ^
/opt/local/lib/perl5/vendor_perl/5.34/darwin-thread-multi-2level/Tk/pTk/tk_f.h:8:
/opt/local/lib/perl5/vendor_perl/5.34/darwin-thread-multi-2level/Tk/pTk/tk.t:16:7: error: type name requires a specifier or qualifier
VFUNC(Var,LangFindVar,V_LangFindVar,_ANSI_ARGS_((Tcl_Interp * interp, Tk_Window, CONST char *name)))
      ^
/opt/local/lib/perl5/vendor_perl/5.34/darwin-thread-multi-2level/Tk/pTk/tk.t:100:51: error: unknown type name 'Tk_Tile'
VFUNC(void,Tk_FreeTile,V_Tk_FreeTile,_ANSI_ARGS_((Tk_Tile tile)))
                                                  ^
/opt/local/lib/perl5/vendor_perl/5.34/darwin-thread-multi-2level/Tk/pTk/tk.t:106:7: error: type name requires a specifier or qualifier
VFUNC(Tk_Tile,Tk_GetTile,V_Tk_GetTile,_ANSI_ARGS_((Tcl_Interp *interp, Tk_Window tkwin,
      ^
/opt/local/lib/perl5/vendor_perl/5.34/darwin-thread-multi-2level/Tk/pTk/tk.t:100:51: error: unknown type name 'Tk_Tile'
VFUNC(void,Tk_FreeTile,V_Tk_FreeTile,_ANSI_ARGS_((Tk_Tile tile)))
                                                  ^
/opt/local/lib/perl5/vendor_perl/5.34/darwin-thread-multi-2level/Tk/pTk/tk.t:106:7: error: type name requires a specifier or qualifier
VFUNC(Tk_Tile,Tk_GetTile,V_Tk_GetTile,_ANSI_ARGS_((Tcl_Interp *interp, Tk_Window tkwin,
      ^

[chrstphrchvz (Christopher Chavez)]

I do not have access to macOS 13 Ventura, and I have not reproduced this issue on macOS 12 Monterey.

I think the actual problem could be during configuration rather than build phase; at a minimum, it is erroneous for p5.xx-tk-tablematrix to use headers like ${prefix}/inlude/tkInt.h from the tk (Tcl/Tk) port. I would also not rule out the problem being caused by something in the p5.xx-tk (Perl/Tk) port.

[chrstphrchvz (Christopher Chavez)]

Replying to chrstphrchvz:

I do not have access to macOS 13 Ventura, and I have not reproduced this issue on macOS 12 Monterey.

Never mind, I had used trace mode even though this issue is only possible without trace mode. I can reproduce this issue on macOS 12 when the tk port is active and by not using trace mode, but I do not believe this issue is specific to certain macOS versions.

At least part of the problem is that the build commands specify -I${prefix}/include before (i.e. with higher precedence than) -I${prefix}/lib/perl5/vendor_perl/5.34/darwin-thread-multi-2level/Tk/pTk, leading to conflicting header files.

[chrstphrchvz (Christopher Chavez)]

I have published Tk-TableMatrix 1.29 which contains a fix for this issue, and have opened a pull request to update the port: ​https://github.com/macports/macports-ports/pull/16612

[chrstphrchvz (Christopher Chavez)]

In dc1bbf6684760901bf9686a5794310882a4b197d/macports-ports (master):

p5-tk-tablematrix: update to 1.29

Fixes: #66157