cmake @3.24.3: Does not compile with SDK 10.12

[lukaso (Lukas Oberhuber)]

This port has stopped successfully compiling on x86_64 with 10.12 SDK. Here is the failure output.

cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_cmake/cmake/work/cmake-3.24.3/Tests/CMakeLib && /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_cmake/cmake/work/cmake-3.24.3/Bootstrap.cmk/cmake -E cmake_link_script CMakeFiles/CMakeLibTests.dir/link.txt --verbose=ON
/Library/Developer/CommandLineTools/usr/bin/clang++ -pipe -Os -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.12.sdk -arch x86_64 -O3 -DNDEBUG -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.12 -Wl,-search_paths_first -Wl,-headerpad_max_install_names -L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX10.12.sdk -arch x86_64 CMakeFiles/CMakeLibTests.dir/CMakeLibTests.cxx.o CMakeFiles/CMakeLibTests.dir/testArgumentParser.cxx.o CMakeFiles/CMakeLibTests.dir/testCTestBinPacker.cxx.o CMakeFiles/CMakeLibTests.dir/testCTestResourceAllocator.cxx.o CMakeFiles/CMakeLibTests.dir/testCTestResourceSpec.cxx.o CMakeFiles/CMakeLibTests.dir/testCTestResourceGroups.cxx.o CMakeFiles/CMakeLibTests.dir/testGccDepfileReader.cxx.o CMakeFiles/CMakeLibTests.dir/testGeneratedFileStream.cxx.o CMakeFiles/CMakeLibTests.dir/testJSONHelpers.cxx.o CMakeFiles/CMakeLibTests.dir/testRST.cxx.o CMakeFiles/CMakeLibTests.dir/testRange.cxx.o CMakeFiles/CMakeLibTests.dir/testOptional.cxx.o CMakeFiles/CMakeLibTests.dir/testString.cxx.o CMakeFiles/CMakeLibTests.dir/testStringAlgorithms.cxx.o CMakeFiles/CMakeLibTests.dir/testSystemTools.cxx.o CMakeFiles/CMakeLibTests.dir/testUTF8.cxx.o CMakeFiles/CMakeLibTests.dir/testXMLParser.cxx.o CMakeFiles/CMakeLibTests.dir/testXMLSafe.cxx.o CMakeFiles/CMakeLibTests.dir/testFindPackageCommand.cxx.o CMakeFiles/CMakeLibTests.dir/testUVProcessChain.cxx.o CMakeFiles/CMakeLibTests.dir/testUVRAII.cxx.o CMakeFiles/CMakeLibTests.dir/testUVStreambuf.cxx.o CMakeFiles/CMakeLibTests.dir/testCMExtMemory.cxx.o CMakeFiles/CMakeLibTests.dir/testCMExtAlgorithm.cxx.o CMakeFiles/CMakeLibTests.dir/testCMExtEnumSet.cxx.o CMakeFiles/CMakeLibTests.dir/testCMFilesystemPath.cxx.o -o CMakeLibTests  ../../Source/libCMakeLib.a ../../Source/libCTestLib.a ../../Source/libCMakeLib.a ../../Source/kwsys/libcmsys.a ../../Utilities/std/libcmstd.a /opt/local/lib/libexpat.dylib /opt/local/lib/libz.dylib /opt/local/lib/libarchive.dylib ../../Utilities/cmjsoncpp/libcmjsoncpp.a /opt/local/lib/libuv.dylib ../../Utilities/cmlibrhash/libcmlibrhash.a -framework CoreFoundation -framework CoreServices /opt/local/lib/libcurl.dylib 
Undefined symbols for architecture x86_64:
  "std::bad_optional_access::~bad_optional_access()", referenced from:
      std::__1::__throw_bad_optional_access() in testOptional.cxx.o
  "typeinfo for std::bad_optional_access", referenced from:
      std::__1::__throw_bad_optional_access() in testOptional.cxx.o
      GCC_except_table21 in testOptional.cxx.o
  "vtable for std::bad_optional_access", referenced from:
      std::__1::__throw_bad_optional_access() in testOptional.cxx.o
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[ryandesign (Ryan Carsten Schmidt)]

Are you using the 10.12 SDK on macOS 10.12 or on a different macOS version?

We have successful builds of this port on all OS versions on our automated buildbot system.

[lukaso (Lukas Oberhuber)]

I believe this is the cause of the problem, which has now hit cmake: ​https://stackoverflow.com/questions/44217316/how-do-i-use-stdoptional-in-c

[lukaso (Lukas Oberhuber)]

I'm building on Big Sur and Ventura and setting the SDK to 10.12 and the minimum os version. I don't have access to CI that can actually run 10.12.

[ryandesign (Ryan Carsten Schmidt)]

Ok. Cross-OS-version compilation is prone to problems like this. However, it ​sounds like this is supposed to work, so it may be a simple bug that can be fixed.

The cmake port requires a C++14 compiler but will use features from C++17 (like "optional") if they are detected to work. It sounds like maybe something has gone wrong with the detection, and it has perhaps determined that "optional" is available on the basis of your Big Sur / Ventura libc++ when it needs to be looking at the Sierra libc++ in the 10.12 SDK that doesn't support it.

Please attach the main.log file. I'm expecting to see a line like:

:info:configure -- Checking if compiler supports needed C++17 constructs - yes

I have not checked but I assume that what the line should say, when compiling for 10.12, is:

:info:configure -- Checking if compiler supports needed C++17 constructs - no

MacPorts contains a patch to that detection which was intended to improve it, but maybe it doesn't work correctly or maybe it recently broke. The patch was added 4 years ago. I don't know why we have this patch in MacPorts rather than submitting it to the developers of cmake. You could try removing the patch to see if that changes anything; maybe in the intervening years upstream fixed the problem a different way that interferes with our patch.

[ryandesign (Ryan Carsten Schmidt)]

Attaching the file $(port work cmake)/*/CMakeFiles/CMakeOutput.log may also help since that tells us what flags were used when checking for "optional" support (where it says "Determining if compiler supports needed C++17 constructs passed with the following output").

[lukaso (Lukas Oberhuber)]

You are absolutely right about the C++17 constructs - yes. I unfortunately can't access the CMakeOutput.log. It's including the right SDK so that doesn't seem to be the problem.

[lukaso (Lukas Oberhuber)]

I worked around this problem by using precompiled cmake, but I'm switching to non-sudo build where that is no longer possible.

Attaching my recent build file.

[lukaso (Lukas Oberhuber)]

Do you think this is happening because the tests are not respecting MACOS_DEPLOYMENT_TARGET and/or SDKROOT but then using them to compile?

[lukaso (Lukas Oberhuber)]

This bug affects 10.13 as well, and cmake-bootstrap as well. My workaround since these are build time dependencies is to build against the latest SDK after installing dependencies (which might be used in the runtime executable of GIMP).

function port_clean_and_install() {
  echo "cleaning and installing $*"
  port clean "$@"
  port_install "$@"
}

# Must be verbose because otherwise times out on circle ci
function port_long_clean_and_install() {
  port clean "$@"
  port -v -N install "$@"
}

  sed -i -e 's/buildfromsource always/buildfromsource ifneeded/g' ${PREFIX}/etc/macports/macports.conf
  sed -i -e 's/macosx_deployment_target/#macosx_deployment_target/g' ${PREFIX}/etc/macports/macports.conf
  sed -i -e 's/macosx_sdk_version/#macosx_sdk_version/g' ${PREFIX}/etc/macports/macports.conf
  (
    # temporarily unset deployment targets since cmake does not build with 10.13 SDK
    # and we don't really care since only used at build time
    unset MACOSX_DEPLOYMENT_TARGET
    unset SDKROOT
    echo "clean cmake-bootstrap****"
    port_clean_and_install cmake-bootstrap
  )
  sed -i -e 's/buildfromsource ifneeded/buildfromsource always/g' ${PREFIX}/etc/macports/macports.conf
  sed -i -e 's/#macosx_deployment_target/macosx_deployment_target/g' ${PREFIX}/etc/macports/macports.conf
  sed -i -e 's/#macosx_sdk_version/macosx_sdk_version/g' ${PREFIX}/etc/macports/macports.conf

  echo "build cmake dependencies in case they are needed for gimp"
  port_clean_and_install libcxx \
    curl \
    expat \
    zlib \
    bzip2 \
    libarchive \
    ncurses \
    libuv

  port_long_clean_and_install llvm-18

  echo "cmake-bootstrap being installed since won't build from source with 10.13 SDK"
  sed -i -e 's/buildfromsource always/buildfromsource ifneeded/g' ${PREFIX}/etc/macports/macports.conf
  sed -i -e 's/macosx_deployment_target/#macosx_deployment_target/g' ${PREFIX}/etc/macports/macports.conf
  sed -i -e 's/macosx_sdk_version/#macosx_sdk_version/g' ${PREFIX}/etc/macports/macports.conf
  (
    # temporarily unset deployment targets since cmake does not build with 10.13 SDK
    # and we don't really care since only used at build time
    # Can be removed once https://trac.macports.org/ticket/66953 is fixed
    unset MACOSX_DEPLOYMENT_TARGET
    unset SDKROOT
    echo "clean cmake****"
    port_clean_and_install cmake
  )
  sed -i -e 's/buildfromsource ifneeded/buildfromsource always/g' ${PREFIX}/etc/macports/macports.conf
  sed -i -e 's/#macosx_deployment_target/macosx_deployment_target/g' ${PREFIX}/etc/macports/macports.conf
  sed -i -e 's/#macosx_sdk_version/macosx_sdk_version/g' ${PREFIX}/etc/macports/macports.conf