Change #37496 seems to have broken lua54-luarocks

[michaellenaghan (Michael Lenaghan)]

Change #3749, revision ​here, seems to have broken lua54-luarocks in this sense:

• Installing lua54-luarocks no longer installs the luarocks and luarocks-admin binaries

To install the luarocks binaries you have to install lua-luarocks:

$ port contents lua-luarocks

Port lua-luarocks contains:
  /opt/local/bin/luarocks
  /opt/local/bin/luarocks-5.1
  /opt/local/bin/luarocks-5.2
  /opt/local/bin/luarocks-5.3
  /opt/local/bin/luarocks-5.4
  /opt/local/bin/luarocks-admin
  /opt/local/bin/luarocks-admin-5.1
  /opt/local/bin/luarocks-admin-5.2
  /opt/local/bin/luarocks-admin-5.3
  /opt/local/bin/luarocks-admin-5.4
  /opt/local/etc/luarocks/config-5.1.lua
  /opt/local/etc/luarocks/config-5.2.lua
  /opt/local/etc/luarocks/config-5.3.lua
  /opt/local/etc/luarocks/config-5.4.lua
  /opt/local/share/luarocks/.turd_lua-luarocks

lua-luarocks forces the installation of lua53 and lua53-luarocks, which is… odd… when I'm only interested in lua54. But worse, running luarocks-5.4 actually selects lua-5.3 by default:

$ luarocks-5.4

...

Configuration:
   Lua:
      Version    : 5.3
      Interpreter: /opt/local/bin/lua5.3 (ok)
      LUA_DIR    : /opt/local/libexec/lua53 (ok)
      LUA_BINDIR : /opt/local/bin (ok)
      LUA_INCDIR : /opt/local/libexec/lua53/include (ok)
      LUA_LIBDIR : /opt/local/libexec/lua53/lib (ok)

   Configuration files:
      System  : /opt/local/etc/luarocks/config-5.3.lua (ok)
      User    : /Users/michaellenaghan/.luarocks/config-5.3.lua (not found)

...

To get the right version of lua you have to specify --lua-version 5.4 on the command-line:

$ luarocks-5.4 --lua-version 5.4

...

Configuration:
   Lua:
      Version    : 5.4
      Interpreter: /opt/local/bin/lua5.4 (ok)
      LUA_DIR    : /opt/local/libexec/lua54 (ok)
      LUA_BINDIR : /opt/local/bin (ok)
      LUA_INCDIR : /opt/local/libexec/lua54/include (ok)
      LUA_LIBDIR : /opt/local/libexec/lua54/lib (ok)

   Configuration files:
      System  : /opt/local/etc/luarocks/config-5.4.lua (ok)
      User    : /Users/michaellenaghan/.luarocks/config-5.4.lua (not found)

...

Finally, luarocks_select no longer seems to work:

$ port select --summary

Name        Selected      Options
====        ========      =======
...
luarocks    none          none
...