Opened 14 months ago

Last modified 14 months ago

#67774 closed defect

libgit2-devel @1.7.0: builds fail for 10.8 thru 10.12: use of undeclared identifier 'errSSLNetworkTimeout' — at Version 1

Reported by: mascguy (Christopher Nielsen) Owned by: mascguy (Christopher Nielsen)
Priority: Normal Milestone:
Component: ports Version: 2.8.1
Keywords: Cc:
Port: libgit2-devel

Description (last modified by mascguy (Christopher Nielsen))

For version 1.7.0, upstream now references constant errSSLNetworkTimeout in their SSL-related code. And that's only available in 10.13+. That change was made by commit:

​https://github.com/libgit2/libgit2/commit/fad90428970e332153027773b517a1606c0efa1f

via ​PR 6535 - Introduce timeouts on sockets

Use of the constant is limited to source file src/libgit2/streams/stransport.c.

While used in two places, one example of the change is as follows.

Previous logic: 

if (ret < 0) {
	st->error = ret;
	return -36; /* ioErr */
}

New logic: 

if (ret < 0) {
	st->error = ret;
	return (ret == GIT_TIMEOUT) ?
	       errSSLNetworkTimeout :
	       -36 /* ioErr */;
}

Change History (1)

comment:1 Changed 14 months ago by mascguy (Christopher Nielsen)

Description: modified (diff)

Initial discussion with upstream initiated via PR comment:

​https://github.com/libgit2/libgit2/pull/6535#issuecomment-1643782431

More to follow.

Note: See TracTickets for help on using tickets.