| 17 | | It can be rectified exactly as stated, by adding a newline after the PortGroup line 62. But it is not mandatory to eliminate all lint warnings; they're only warnings, not errors, and in this case only appear in nitpick mode. This lint warning was originally created back when portgroups were only included at the top of the Portfile. The idea was that the Portfile should begin with the Subversion `$Id$` comment (removed after we moved to GitHub in 2016), the modeline, a blank line, the PortSystem line, any PortGroup lines, a blank line, and then the name, version, etc. The blank line after the PortGroup line is often omitted when it appears later in the Portfile, such as within a variant or subport. Maybe the lint warning should not appear for such later uses. |
| | 17 | It can be rectified exactly as stated, by adding a newline after the PortGroup line 62: |
| | 18 | |
| | 19 | {{{#!diff |
| | 20 | diff --git a/net/nmap/Portfile b/net/nmap/Portfile |
| | 21 | index 0e668802021..a42589cb873 100644 |
| | 22 | --- a/net/nmap/Portfile |
| | 23 | +++ b/net/nmap/Portfile |
| | 24 | @@ -59,6 +59,7 @@ default_variants +ssl +pcre |
| | 25 | |
| | 26 | variant ssl description {build with ssl support} { |
| | 27 | PortGroup openssl 1.0 |
| | 28 | + |
| | 29 | openssl.branch 3 |
| | 30 | configure.args-append --with-openssl=[openssl::install_area] |
| | 31 | } |
| | 32 | }}} |
| | 33 | |
| | 34 | But it is not mandatory to eliminate all lint warnings; they're only warnings, not errors, and in this case only appear in nitpick mode. This lint warning was originally created back when portgroups were only included at the top of the Portfile. The idea was that the Portfile should begin with the Subversion `$Id$` comment (removed after we moved to GitHub in 2016), the modeline, a blank line, the PortSystem line, any PortGroup lines, a blank line, and then the name, version, etc. The blank line after the PortGroup line is often omitted when it appears later in the Portfile, such as within a variant or subport. Maybe the lint warning should not appear for such later uses. |
