Changes between Version 1 and Version 9 of Ticket #68148


Ignore:
Timestamp:
Sep 12, 2023, 3:21:02 PM (13 months ago)
Author:
mascguy (Christopher Nielsen)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #68148

    • Property Cc cjones051073 catap added
    • Property Status changed from assigned to closed
    • Property Resolution changed from to fixed
    • Property Summary changed from libgit2 @1.7.1: builds fail with xcode clang 6 and earlier: error: unknown type name 'inline' to libgit2 @1.7.1: builds fail with xcode clang 6 and earlier: error: unknown type name 'inline', from legacy-support header 'dirent.h'

  • Ticket #68148 – Description

    v1 v9  
    1 Despite the project setting the C standard to 90 - which should (?) be sufficient - builds are failing due to keyword 'inline':
     1A recent addition to `legacy-support` added some functions declared inline, per PR:
     2- [https://github.com/macports/macports-legacy-support/pull/61 PR 61 - Fix fdopendir so dirfd stays open until closedir (for fstatat etc)]
     3
     4However, upstream's project compiles with the C standard set to 90, which doesn't support keyword `inline`. Instead, compiling with C 99 or later is required.
    25
    36{{{
    … …  
    710       ^
    811}}}
    9 
    10 More frustratingly, `libgit2-devel` was updated to to this version three weeks ago, and it built successfully across-the-board. (Including 10.5, based on local testing.) So it's not clear what else has changed in that short time.