mpich-clang16 @4.1.1: incompatible function pointer types passing ssize_t

[platipodium (Carsten Lemmen)]

Building libfabric as part of mpich-clang16 fails on macOS 14

cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_mpich/mpich-clang16/work/mpich-4.1.1/modules/libfabric
make
        ^
prov/hook/src/hook_domain.c:124:12: error: incompatible function pointer types passing 'ssize_t (struct fid_ep *, size_t)' (aka 'long (struct fid_ep *, unsigned long)') to parameter of type 'ssize_t (*)(struct fid_ep *, uint64_t)' (aka 'long (*)(struct fid_ep *, unsigned long long)') [-Wincompatible-function-pointer-types]
                                                     hook_credit_handler);
                                                     ^~~~~~~~~~~~~~~~~~~
prov/hook/src/hook_domain.c:150:17: error: incompatible function pointer types initializing 'void (*)(struct fid_ep *, uint64_t)' (aka 'void (*)(struct fid_ep *, unsigned long long)') with an expression of type 'void (struct fid_ep *, size_t)' (aka 'void (struct fid_ep *, unsigned long)') [-Wincompatible-function-pointer-types]
        .add_credits = hook_add_credits,
                       ^~~~~~~~~~~~~~~~
prov/hook/src/hook_domain.c:152:22: error: incompatible function pointer types initializing 'void (*)(struct fid_domain *, ssize_t (*)(struct fid_ep *, uint64_t))' (aka 'void (*)(struct fid_domain *, long (*)(struct fid_ep *, unsigned long long))') with an expression of type 'void (struct fid_domain *, ssize_t (*)(struct fid_ep *, size_t))' (aka 'void (struct fid_domain *, long (*)(struct fid_ep *, unsigned long))') [-Wincompatible-function-pointer-types]
        .set_send_handler = hook_set_send_handler,
                            ^~~~~~~~~~~~~~~~~~~~~
4 warnings and 3 errors generated.

[aaschwanden (Andy Aschwanden)]

The same error occurs for mpich-clang17.

[eborisch (Eric A. Borisch)]

Is this still the case for you with 4.1.2?

[eborisch (Eric A. Borisch)]

Possible solution (see patch attached to ticket): ​https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271537

I don't have time to research this, but if someone else would like to give it a shot...

[eborisch (Eric A. Borisch)]

I think 4.1.2 may have included this fix, based on a quick spot-check.

[platipodium (Carsten Lemmen)]

Both mpich-clang16 and mpich-clang17 (version4.1.2) install fine for me now. Seems fixed.

[mascguy (Christopher Nielsen)]

Replying to platipodium:

Both mpich-clang16 and mpich-clang17 (version4.1.2) install fine for me now. Seems fixed.

Great, glad it's fixed!