| 7 | | However, I noticed a problem with `setreuid`/`setregid` on 10.4, which is needed by the LegacySupport implementation of `faccessat`. They return `0` but they aren't correct. They set the effective uid/gid but not the real uid/gid. This doesn't affect the automatic `make test` tests, because they aren't run setuid/setgid. But if someone manually runs `sudo make test_faccessat_setuid`, those tests would fail. Since the `faccessat` implementation has only just started working at all on other platforms, this probably isn't important, but I thought I should mention it. Maybe `setreuid` and `setregid` should/could be fixed as well (separately to this). |
| | 7 | However, I noticed a problem with `setreuid`/`setregid` on 10.4, which is needed by the LegacySupport implementation of `faccessat`. They return `0` but they aren't correct. They set the effective uid/gid but not the real uid/gid. This doesn't affect the automatic `make test` tests, because they aren't run setuid/setgid. But if someone manually runs `sudo make test_faccessat_setuid`, those tests would fail. Since the `faccessat` implementation has only just started working at all on other platforms, this probably isn't important, but I thought I should mention it. Maybe `setreuid` and `setregid` should/could be fixed as well (separately to this). Or maybe the local system implementation on 10.4 should be accepted for what it is? |
