Changes between Initial Version and Version 1 of Ticket #68931


Ignore:
Timestamp:
Dec 17, 2023, 7:09:36 PM (9 months ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

I assume you mean 6.8.0 and 6.8.1 rather than 3.8.0 and 3.8.1.

The problem is that the revision was not increased when #68898 was resolved. macOS Ventura and later contain a new implementation of patch that behaves differently from that in older macOS versions. In older macOS versions an error was issued when asked to apply a patch that was already applied, which was what prompted #68898. But the patch program in Ventura and later silently applied the patch in reverse.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #68931

    • Property Cc reneeotten added
    • Property Owner set to michaelld
    • Property Status changed from new to assigned

  • Ticket #68931 – Description

    initial v1  
    1 There was a bug in the 3.8.0 version of py-sip. This bug was fixed [two weeks](https://www.riverbankcomputing.com/hg/sip/rev/67e0294b505c) ago in 3.8.1.
    2 This also solved [68828](https://trac.macports.org/ticket/68828).
     1There was a bug in the 3.8.0 version of py-sip. This bug was fixed [https://www.riverbankcomputing.com/hg/sip/rev/67e0294b505c two weeks] ago in 3.8.1.
     2This also solved #68828.
    33Now the 3.8.1 is available. Somehow the old code ended up in the builds of the pre-build 3.8.1 version.
    44
    … …  
    77
    88There we see the old code:
    9 ```
     9{{{
    1010opt/local/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/sipbuild/generator/outputs/code.py
    11118417:    if klass.docstring is None or klass.docstring.signature is not SocstringSignature.DISCARDED:
    12 ```
     12}}}
    1313
    14 I don't understand how this old codes ends up in this file. I checked the [distfile](https://ftp.fau.de/macports/distfiles/py-sip/sip-6.8.1.tar.gz) and that contains the correct code (without the typo *Soc*string).
     14I don't understand how this old codes ends up in this file. I checked the [https://ftp.fau.de/macports/distfiles/py-sip/sip-6.8.1.tar.gz distfile] and that contains the correct code (without the typo *Soc*string).
    1515
    1616