orc @0.4.35_1: fails in build stage on MacBook Pro M2, Sonoma 14.3

[zzanderr]

:info:build [48/123] ccache /usr/bin/clang -Iorc-test/liborc-test-0.4.0.dylib.p -Iorc-test -I../orc-0.4.35/orc-test -I. -I../orc-0.4.35 -I/opt/local/include -fdiagnostics-color=always -Wall -Winvalid-pch -O2 -g -DHAVE_CONFIG_H -Wno-implicit-int -Wno-implicit-function-declaration -fvisibility=hidden -pipe -Os -std=c99 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -arch arm64 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -DORC_ENABLE_UNSTABLE_API -D_GNU_SOURCE -DBUILDING_ORC_TEST -MD -MQ orc-test/liborc-test-0.4.0.dylib.p/orctest.c.o -MF orc-test/liborc-test-0.4.0.dylib.p/orctest.c.o.d -o orc-test/liborc-test-0.4.0.dylib.p/orctest.c.o -c ../orc-0.4.35/orc-test/orctest.c
:info:build FAILED: orc-test/liborc-test-0.4.0.dylib.p/orctest.c.o
:info:build ccache /usr/bin/clang -Iorc-test/liborc-test-0.4.0.dylib.p -Iorc-test -I../orc-0.4.35/orc-test -I. -I../orc-0.4.35 -I/opt/local/include -fdiagnostics-color=always -Wall -Winvalid-pch -O2 -g -DHAVE_CONFIG_H -Wno-implicit-int -Wno-implicit-function-declaration -fvisibility=hidden -pipe -Os -std=c99 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -arch arm64 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -DORC_ENABLE_UNSTABLE_API -D_GNU_SOURCE -DBUILDING_ORC_TEST -MD -MQ orc-test/liborc-test-0.4.0.dylib.p/orctest.c.o -MF orc-test/liborc-test-0.4.0.dylib.p/orctest.c.o.d -o orc-test/liborc-test-0.4.0.dylib.p/orctest.c.o -c ../orc-0.4.35/orc-test/orctest.c
:info:build ../orc-0.4.35/orc-test/orctest.c:68:22: error: expected ')' 
:info:build   asm("msr FPCR, %0" : : "r" (fpcr_value));
:info:build                      ^   
:info:build ../orc-0.4.35/orc-test/orctest.c:68:6: note: to match this '(' 
:info:build   asm("msr FPCR, %0" : : "r" (fpcr_value));
:info:build      ^   
:info:build 1 error generated.

[zzanderr]

orc build log

[zzanderr]

I tried again with ccache disabled, and it failed with the same message.

[zzanderr]

orc @0.4.35_0 builds fine.

[llucps]

I'm getting exactly the same error on a Mac mini M1 with Sonoma 14.3 and Xcode 15 installed.

[jmroot (Joshua Root)]

Fails the same way on the buildbot: ​https://build.macports.org/builders/ports-14_arm64-builder/builds/13904

[ryandesign (Ryan Carsten Schmidt)]

I've reported it to the developers: ​https://gitlab.freedesktop.org/gstreamer/orc/-/issues/59

[fvaccari]

I see this comment in ​https://build.macports.org/builders/ports-14_arm64-builder/builds/13904

orc: use -stc=c99 to fix building

I just made a port selfupdate and see that the portfile has

configure.cflags-append \
                    -std=c99

That breaks the installation on my Ventura (13.6.4) system with Xcode 14.3.1. If I comment the -std=c99 addition orc builds and installs again.

Maybe the change should apply only to Sonoma (or newer Xcode...)

[ryandesign (Ryan Carsten Schmidt)]

The -std=c99 fix was not for Sonoma; it was for ancient systems that default to c89. If that breaks installation on your Ventura system, please file a new ticket with the details; it's unrelated to this ticket which is about build failures on arm64 due to the assembly syntax used.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign:

it's unrelated to this ticket

I guess I don't know that for sure. And I see that you were not Cc'd on this ticket before so you may not have seen my previous message; please open the ticket URL to see it.

You didn't mention if you're on x86_64 or arm64. If you're on x86_64 and -std=c99 breaks building this port from source, then file a new ticket.

If you're on arm64 and removing -std=c99 fixes building this port from source, then that's very interesting and would indeed be relevant, and I'll see if I can test on an arm64 system. It's possible that -std=gnu99 would cover all the bases.

[ryandesign (Ryan Carsten Schmidt)]

Ok indeed 0.4.35_0 build successfully on arm64: ​https://build.macports.org/builders/ports-14_arm64-builder/builds/13528

But 0.4.35_1 failed on arm64; that was when -std=c99 was added: ​https://build.macports.org/builders/ports-14_arm64-builder/builds/13904

If someone on arm64 can check if changing that to -std=gnu99 works, please let us know. If that works, you can submit a PR for that fix.

[kencu (Ken)]

-std=gnu99 works on arm64 Sonoma, yes

[kencu (Ken)]

In aa327dd8eaed762741880f39078efb0d443e5b5e/macports-ports (master):

orc: tweak C std to gnu99

closes: #69206

[Nailig]

yes, that works for me too

[barracuda156]

Just saw this, thanks for fixing it.

16. S. Quite amazing that c99 breaks it on one system.

[fvaccari]

Referring to my previous comment (#9), I'm on arm64, Ventura 13.6.4 system with Xcode 14.3.1.

std=c99 fails

std=gnu99 builds and installs

Removing the -std flag builds and installs