Changes between Initial Version and Version 1 of Ticket #70253, comment 3


Ignore:
Timestamp:
Jun 20, 2024, 2:50:13 PM (3 months ago)
Author:
bernstei
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #70253, comment 3

    initial v1  
    1 So, I know this ticket is closed as being a duplicate of 61842, but it is not.  Can it be reopened?  61842 involves source autogenerated by lexx/yacc/bison, and I don't think is feasible to fix.  This one involves static source in opendx itself, and may be fixable.
     1So, I know this ticket is closed as being a duplicate of 61842, but it is not.  Can it be reopened?  61842 involves source autogenerated by lexx/yacc/bison, and I don't think is feasible to fix except by adding compiler flag workarounds.  This one involves static source in opendx itself, and may be fixable by updating the source.
    22
    33I've been looking more carefully, and I've fixed a number of issues, but I can tell you that it's just a mess. For example, it's giving c++11-narrowing errors because of trying to put values > 128 into a char array. It's easy to fix that problem by making it unsigned char, but then there's an error passing it to the relevant X function (XCreatePixmapFromBitmapData in this case), so they have to be cast back to (char *).  Anyway, it's manageable so far, but I'd just like to point out that this is a very large and _old_ port, that has many assumptions, now outdated, about how compilers behave.