Context Navigation

Changes between Version 2 and Version 3 of Ticket #70253, comment 3

v2	v3
3	3	I've been looking more carefully, and I've fixed a number of issues, but I can tell you that it's just a mess. For example, it's giving c++11-narrowing errors because of trying to put values > 128 into a char array. It's easy to fix that problem by making it unsigned char, but then there's an error passing it to the relevant X function (XCreatePixmapFromBitmapData in this case), so they have to be cast back to (char *). Anyway, it's manageable so far, but I'd just like to point out that this is a very large and _old_ port, that has many assumptions, now outdated, about how compilers behave.
4	4
5		[edited - there are tens of instances of this particular error - a bitmap stored as raw bits in an array of char instead of unisgned char, but the relevant X functions expecting char *]
	5	[edited - there are tens of instances of this particular error - a bitmap stored as raw bits in an array of char instead of unsigned char, but the relevant X functions expecting char *]
6	6
7	7	I think it's quite likely that it's much more sustainable to set the compilers to behave like their older versions, which the opendx developers assumed, than to update opendx to modern standards. Certainly the resulting patch for this ticket is much smaller that way.