Opened 18 years ago

Closed 18 years ago

#10277 closed enhancement (fixed)

UPDATE chmdump - portfile doesn't specify endian flag

Reported by: jalkut@… Owned by: digdog@…
Priority: Normal Milestone:
Component: ports Version: 1.2
Keywords: Cc: digdog@…
Port:

Description

The chmdump built by the current portfile doesn't set the BIG_ENDIAN flag when building, which prevents the input files processed by the tool from being read correctly.

The diff is simple:

24c24 < build.args CFLAGS="-D_POSIX_SOURCE -DBIG_ENDIAN" ---

build.args CFLAGS=-D_POSIX_SOURCE

I tested with the Portfile modified on my system and "port -s install chmdump" to rebuild from source. The behavior before was a bus error on a typical chm file, and after the tool works as expected.

Change History (6)

comment:1 Changed 18 years ago by jalkut@…

Sorry I think the diff I pasted was in the wrong order - from new to old. But you should be able to get the idea.

comment:2 Changed 18 years ago by jalkut@…

Sorry this is my first bug report - I neglected to include the required info:

Darwin DanielG5.local 8.7.0 Darwin Kernel Version 8.7.0: Fri May 26 15:20:53 PDT 2006; root:xnu-792.6.76.obj~1/RELEASE_PPC Power Macintosh powerpc

Version: 1.211

comment:3 Changed 18 years ago by markd@…

Type: defectenhancement

comment:4 Changed 18 years ago by markd@…

Would this break the port on Intel? If so we'd need to conditionally set this flag only for PPC.

comment:5 Changed 18 years ago by markd@…

Cc: digdog@… added
Owner: changed from macports-tickets@… to digdog@…

Assign to maintainer.

comment:6 Changed 18 years ago by digdog@…

Resolution: fixed
Status: newclosed

Fixed in changeset 19864.

I only add this flag for powerpc platform, cause x86 version will cause bus on intel mac error if added.

Note: See TracTickets for help on using tickets.