BUG: swi-prolog-5.6.17 won't build on 10.3

[darren.bane@…]

swi-prolog-5.6.17

the error log can be found here: INLINE

Description: Broken build on 10.3

Comments: The patch against pl-tai.c is a workaround for OS X's non-POSIX compliance, so probably shouldn't be passed upstream.

I tried to put wielemak@… and darwinports@… in the "Assigned To" and "Cc" fields but Bugzilla wouldn't let me.

================INLINE CONTENT================ % sudo port install swi-prolog

!snip!

gcc -c -I. -I/opt/local/var/db/dports/build/_opt_local_var_db_dports_sources_rsync.rsync.darwinports.org_dpupdate_dports_lang_swi-prolog/work/pl-5.6.17/src -I/opt/local/var/db/dports/build/_opt_local_var_db_dports_sources_rsync.rsync.darwinports.org_dpupdate_dports_lang_swi-prolog/work/pl-5.6.17/src/rc -Wall -O3 -fno-strict-aliasing -no-cpp-precomp -fno-common pl-tai.c -o pl-tai.o pl-tai.c:44: error: `timezone' redeclared as different kind of symbol /usr/include/time.h:141: error: previous declaration of `timezone'

and after fixing this ...

gcc -c -Wall -O2 -fno-strict-aliasing -I. -I/opt/local/var/db/dports/build/_opt_local_var_db_dports_sources_rsync.rsync.darwinports.org_dpupdate_dports_lang_swi-prolog/work/pl-5.6.17/packages/xpce/src -I/usr/X11R6/include -I/usr/X11R6/include -I/opt/local/include -I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include -DXTHREADS -I/opt/local/include -I/usr/X11R6/include -fno-common -no-cpp-precomp -DHAVE_CONFIG_H x11/xcommon.c -o x11/xcommon.o In file included from /usr/X11R6/include/X11/Xft/Xft.h:35,

from x11/include.h:76, from x11/xcommon.c:28:

/opt/local/include/freetype2/freetype/freetype.h:20:2: #error "`ft2build.h' hasn't been included yet!" /opt/local/include/freetype2/freetype/freetype.h:21:2: #error "Please always use macros to include FreeType header files." /opt/local/include/freetype2/freetype/freetype.h:22:2: #error "Example:" /opt/local/include/freetype2/freetype/freetype.h:23:2: #error " #include <ft2build.h>" /opt/local/include/freetype2/freetype/freetype.h:24:2: #error " #include FT_FREETYPE_H"

[darren.bane@…]

Workaround for OS X's lack of POSIX timezone and daylight globals

[darren.bane@…]

Conform to newer Freetype's recommended #include practice

[gwright@…]

I'll give this a try and commit.

/Greg

[darren.bane@…]

Sorry, just noticed the comment above tz_daylight() in my first patch was never changed after copying-and-pasting. "tz_offset() tests whether summer time is in effect" would be appropriate.

[markd@…]

swi-prolog is up to 5.6.19 now. Is it still broken on 10.3? Also, 5.6.20 just came out.

[darren.bane@…]

Yes, it's still broken on 10.3. Well, like I said, I actually consider Mac OS X and not swipl to be broken here. I needed to apply this patch (with appropriate fuzz) to get version 5.6.19 to build. I know about 5.6.20, but wanted features from 5.6.19 (pldoc and plunit) and have no such needs from 5.6.20.

[markd@…]

Well if these patches fix building on 10.3 that'd be a good thing. But ordinarily I'd think it also should be updated unless there is a special reason not to. Is updating to 5.6.20 a bad idea?

[darren.bane@…]

Updating to 5.6.20 is an excellent idea, I was just lazy ;-)

The pl-tai.c build breakage was reported independently upstream ( ​http://gollem.science.uva.nl/bugzilla/show_bug.cgi?id=206 ), and it turns out that my patch-pl-tai.c is wrong. You may want to wait until the upstream bug is resolved before committing that. patch-include.h is still good to go though.

[darren.bane@…]

Better patches to fix both these problems have been committed in upstream CVS, so I recommend that this bug be closed, and we just wait for the next upstream release.

[markd@…]

Very good, closing. Thanks for your diligence on this.