Opened 18 years ago

Closed 18 years ago

Last modified 9 years ago

#10657 closed defect (fixed)

BUG: aalib-1.4rc5 patching ltmain.sh fails

Reported by: markus_kranz@… Owned by: yeled@…
Priority: High Milestone:
Component: ports Version: 1.3.2
Keywords: Cc: yves@…
Port: aalib

Description (last modified by ryandesign (Ryan Carsten Schmidt))

When trying to install gimp2, I get the following error concerning aalib:

ip102:/opt/local/var/db/dports admin$ sudo port install gimp2
--->  Fetching aalib
--->  Attempting to fetch aalib-1.4rc5.tar.gz from ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/distfiles/
--->  Verifying checksum(s) for aalib
--->  Extracting aalib
--->  Applying patches to aalib
Error: Target com.apple.patch returned: shell command "cd "/opt/local/var/db/dports/build/_opt_local_var_db_dports_sources_rsync.rsync.darwinports.org_dpupdate_dports_graphics_aalib/work/aalib-1.4.0" && patch -p0 < "/opt/local/var/db/dports/sources/rsync.rsync.darwinports.org_dpupdate_dports/graphics/aalib/files/patch-ltmain.sh.diff"" returned error 1
Command output: patching file ./ltmain.sh
Hunk #85 FAILED at 4280.
1 out of 139 hunks FAILED -- saving rejects to file ./ltmain.sh.rej

Error: The following dependencies failed to build: aalib gimp-print gtk2 atk glib2 pkgconfig pango Xft2 fontconfig expat xrender render cairo tiff lcms libart_lgpl libexif libmng libwmf p5-xml-parser perl5.8
Error: Status 1 encountered during processing.

I'm using Apple xcode 2.4

ip102:/opt/local/etc/ports admin$ xcodebuild -version
Component versions: DevToolsCore-757.0; DevToolsSupport-733.0

and

ip102:/opt/local/etc/ports admin$ port version
Version: 1.320

What can I do to solve the problem?

Regards,
Markus

Change History (6)

comment:1 Changed 18 years ago by yves@…

Cc: yves@… added

comment:2 Changed 18 years ago by markd@…

Summary: aalib - patching ltmain.sh failsBUG: aalib-1.4rc5 patching ltmain.sh fails

comment:3 Changed 18 years ago by puetzk@…

The problematic hunk of the patch is this one:

@@ -2617,27 +4280,27 @@
 	  fi
 
 	  pic_flag_for_symtable=
-	  case "$host" in
+	  case $host in
 	  # compiling the symbol table file with pic_flag works around
 	  # a FreeBSD bug that causes programs to crash when -lm is
 	  # linked before any other PIC object.  But we must not use
 	  # pic_flag when linking with -static.  The problem exists in
 	  # FreeBSD 2.2.6 and is fixed in FreeBSD 3.1.
-	  *-*-freebsd2*|*-*-freebsd3.0*|*-*-freebsdelf3.0*)
+	  *-*-freebsd2*|*-*-freebsd3.0*|*-*-freebsdelf3.0*)
 	    case "$compile_command " in
 	    *" -static "*) ;;

There is a stray CRLF in the source file at the end of the *-*-freebsd2* line (the rest of the file uses only LF), so the hunk doesn't match. I would guess that the patch was meant to fix this as part of its changes (since it touches that line, but doesn't actually chnge it), but got passed through a linefeed (or even just modified in a text editor) in such a way that the CR got removed.

comment:4 Changed 18 years ago by yves@…

I just removed the offending hunk, too bad for freebsd users ;-)

changeset:22729

comment:5 Changed 18 years ago by kballard (Lily Ballard)

Resolution: fixed
Status: newclosed

Sounds like this ticket should have been closed when [22729] was committed.

comment:6 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Port: aalib added
Note: See TracTickets for help on using tickets.