[UPDATE] MPlayer 1.0rc1

[ecronin (Eric Cronin)]

Attached is an update to the MPlayer port. I'm also willing to take semi-maintainership of the port (updates from others, especially w.r.t. i386, are very welcome)

This update contains a number of changes:

• version bump to 1.0rc1
• support for i386
  • variant for i386 binary codecs, but loading disabled due to reported issues with wine
• removed a large number of possible implicit dependencies due to configure auto-detecting support libraries
• addition of variants for support libraries present in MacPorts

I've tested pretty thoroughly on darwin 8 powerpc, all variants where the required port currently builds build and run ok. i386 testing is incomplete.

[adamw@…]

This does not build on i386. There is no --disable-loader flag; it was an error on behalf of the MPlayer folks. You want to use --disable-win32 there instead.

Also, doesn't it seem a bit overkill to require ports of zlib and unzip? I can't imagine how MPlayer would have managed to zip or gzip a package so poorly that the Apple-supplied unzip or zlib is insufficient.

[adamw@…]

p.s. same argument with libiconv.

kthx.

[ecronin (Eric Cronin)]

Portfile updated and re-attached to use --disable-win32.

The zlib, zip, and iconv requires are carried over from the original Portfile. I'm fairly neutral one way or the other on zip, although there seems to be an advantage to linking against macports provided libs.

[markd@…]

Their was a duplicate submision of the mplayer update and someone else's patch got committed. Still no maintainer though so I can make you maintainer and you can review the updated mplayer and make changes if you wish.

[fracai@…]

That duplicate submission ticket:8230 omits the --disable-win32 flag and fails to compile. I've posted there as well and reopened the ticket.

[ecronin (Eric Cronin)]

I think this update safely supersedes the currently committed 1.0rc1 Portfile (contains the change from ticket:8230 plus additional updates listed in the original report above), probably with revision 1 needed. The patch to Makefile is still needed on older versions of darwin and should be resurrected with the updated patch-Makefile attached to this bug.

I would still appreciate input from i386 users, particularly on the wine-related issues which currently require --disable-win32 and prevent the +binarycodecs variant from functioning.

[fracai@…]

It's interesting that markd is reporting successful compile on a MacBook Pro, I see errors with my iMac. These two tickets should probably be merged.

[fracai@…]

OK, --disable-win32 is probably a good idea, but it's only needed if you have a /usr/local/libs/codecs directory.

[markd@…]

Eric, I can't get your patch to work for the resurrected Makefile patch. Can you provide a new patch? -Mark

[ecronin (Eric Cronin)]

The patch at ​https://svn.macosforge.org/projects/macports/attachment/ticket/10948/patch-Makefile applies cleanly for me (this is a replacement for the resurrected patch-Makefile, not a patch to patch-Makefile)

[adamw@…]

As posted in ticket:8230...

The loader code that supports the win32 codecs is based upon Wine. That code, however, is broken on i386 Darwin.

If somebody has the codecs installed in /usr/local/lib/codecs, mplayer will not compile without --disable-win32. If somebody does NOT have the codecs installed, mplayer will automatically compile with --disable-win32.

Hence, adding the flag will make mplayer compile in i386-Darwin, and will not affect anybody else.

The Portfile and patch in this ticket are both good. They work perfectly for me, and build on my i386-Darwin box, and my G4-Darwin box, both with and without the win32 codecs installed. The files in this bug report should be committed.

MPlayer is currently unable to utilize those codecs, but having them installed shouldn't prevent the port from building.

[danielluke (Daniel J. Luke)]

Sorry to cause confusion on this, I've gone ahead and committed the attached files.