BUG: jpilot doesn't build with +gtk2 (two problems, patches attached)

[tristan@…]

jpilot with the +gtk2 variant doesn't build, for two reasons. First:

expense.c: In function 'clear_details':
expense.c:681: warning: implicit declaration of function
'gtk_text_backward_delete'
expense.c:681: warning: implicit declaration of function 'GTK_TEXT'
expense.c:682: warning: implicit declaration of function
'gtk_text_get_length'

This is because the Portfile is appending "--enable-gtk2" which is now the default (see ​http://www.jpilot.org/pipermail/jpilot/2005-December/005616.html)

One solution is to remove the "--enable-gtk2" line from the Portfile. Another alternative might be to make gtk2 the default and gtk1 the variant, since gtk2 is now the default for jpilot. The attached Portfile does this.

The second problem is that jpilot doesn't build because _NL_TIME_FIRST_WEEKDAY is undeclared. This is a known bug and I am attaching the FreeBSD patch for this (see ​http://www.freebsd.org/cgi/query-pr.cgi?pr=103203).

[tristan@…]

updated jpilot Portfile (gtk2 is default instead of gtk1)

[tristan@…]

patch to fix undeclared _NL_TIME_FIRST_WEEKDAY

[tristan@…]

Edit: I've found another problem, which is that jpilot doesn't load plugins on MacOS (it is looking for .so files instead of .dylib files). I've attached an updated patch-plugins.c which fixes this. I've also submitted this to the jpilot maintainer, so it may well appear upstream at some point.

[tristan@…]

updated plugins patch so that plugins actually work on MacOS

[markd@…]

Committed. Thanks!