BUG: uninstall should consider upgraded ports before failing

[yves@…]

Example (the story is real, only the versions numbers have been changed) :

port upgrade gtk2
	...
port installed :
	gtk2 2.10.4
	gtk2 2.10.8 (active)
port uninstall inactive :
	can't uninstall gtk2 2.10.4 because gimp2 depends on it.

[yves@…]

example rewritten with decent formatting

port upgrade gtk2
    ...

port installed :
    gtk2 2.10.4
    gtk2 2.10.8 (active)

port uninstall inactive :
    can't uninstall gtk2 2.10.4 because gimp2 depends on it.

[jmpalacios (Juan Manuel Palacios)]

Milestone Feature Requests deleted

[jmroot (Joshua Root)]

Simple fix attached: don't error out due to dependents unless this is the only version of the port installed.

Nominating for the upcoming release.

[raimue (Rainer Müller)]

Acceptable solution. But this will not reduce the need to use -f when also using -u on upgrade because uninstall comes before installing.

$ sudo port -unf upgrade less
...
--->  Deactivating less @418_0
--->  Uninstalling less @418_0
--->  Installing less @418_0
--->  Activating less @418_0

But that would be another issue, let's get this one fixed first.

[yves@…]

Thanks for looking into this.

I don't know much of the inner workings but the test could balso check if the port to be uninstalled is active or not :

if {$nb_versions_installed == 1

port_is_active} {

[yves@…]

em ... forgot to pre-format the thing

if {$nb_versions_installed == 1 || port_is_active} {

Of course, port_is_active probably does not exists as such, unless I am very lucky.

[jmroot (Joshua Root)]

Replying to yves@macports.org:

I don't know much of the inner workings but the test could also check if the port to be uninstalled is active or not :

The activation status is available in the registry entry. Though, to trip this check with more than one version of the port installed, you must have specifically asked to uninstall the active version, either directly or through a pseudo-port. We could assume the user knows what he's doing and is going to activate the other version after uninstalling this one, or we could assume he's done something silly like entered the wrong version number or said 'port uninstall active'. I guess it is better to err on the side of caution and make him either use -f or deactivate first.

[jmroot (Joshua Root)]

proposed fix

[jmroot (Joshua Root)]

Committed the patch to trunk in r36747. Leaving this ticket open until the change is either merged to the branch or retargeted to a later release.

[raimue (Rainer Müller)]

Marking fixed, targeted for 1.7.0.