Opened 17 years ago

Closed 17 years ago

Last modified 16 years ago

#12037 closed update (fixed)

UPDATE: xqf-1.0.5

Reported by: anddam (Andrea D'Amore) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: adamore@…,markd@…
Port:

Description

Macports provides XQF 1.0.3, XQF compiles fine but doesn't run properly when called. I patched this by changing a dlsym() parameter that prevented in source xpms to be found.

I've also patched an internal function in order to launch executables with a space in their name, this allows to launch game such as "Wolfenstein ET" that has a space in the exec name. The workaround is done escaping white spaces with a backslash.

I've created a patch file with both fixes and I've tried it with xqf 1.0.5 . I tried from clear sources applying the patch and then using the same config line I found in macports 1.0.3 . I had to remove a few LDFLAGS and did it patching makefile.am and makefile.in as I didn't knew how to do it via configuration line .

Attachments (2)

file.patch (3.6 KB) - added by suppa@… 17 years ago.
Portfile (1.4 KB) - added by adamore@… 17 years ago.
Portfile for xqf 1.0.5

Download all attachments as: .zip

Change History (14)

Changed 17 years ago by suppa@…

Attachment: file.patch added

comment:1 Changed 17 years ago by markd@…

Milestone: Port Enhancements
Summary: xqf 1.0.5UPDATE: xqf-1.0.5

comment:2 Changed 17 years ago by adamore@…

Any comment about how to remove LDFLAGS via the config script ?

comment:3 Changed 17 years ago by nox@…

Milestone: Port EnhancementsPort Updates
Priority: ExpectedNormal
Type: defectenhancement
Version: 1.4.42

comment:4 Changed 17 years ago by markd@…

Cc: adamore@… markd@… added

Sorry no one responded earlier. You can remove CFLAGS by using configure.cflags-delete. So what needs to be done to complete the update?

comment:5 Changed 17 years ago by raimue (Rainer Müller)

Shouldn't this kind of patch rather be applied upstream as it fixes a general bug in the software?

comment:6 Changed 17 years ago by adamore@…

What do you mean by "applying upstream" the patch?

comment:7 Changed 17 years ago by raimue (Rainer Müller)

Your patch fixes bugs in xqf. Please also send this patch to the author of xqf.

comment:8 Changed 17 years ago by adamore@…

I already did it, as far as I remember, but I never got any reply. XQF seems an "old" project with 1 or 2 minor update at year, one in 2006, none in 2007.

Changed 17 years ago by adamore@…

Attachment: Portfile added

Portfile for xqf 1.0.5

comment:9 Changed 17 years ago by adamore@…

Rename "file.patch" to patch-xqf-1.0.5 before committing it.

comment:10 Changed 17 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: newclosed

Committed in r35969.

comment:11 Changed 16 years ago by jmroot (Joshua Root)

Type: enhancementupdate

comment:12 Changed 16 years ago by (none)

Milestone: Port Updates

Milestone Port Updates deleted

Note: See TracTickets for help on using tickets.