Opened 17 years ago

Closed 17 years ago

Last modified 16 years ago

#12096 closed update (fixed)

boost 1.33.1 -> boost 1.34 portfile diff

Reported by: sanchom (Sancho McCann) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: boost Cc: sanchom (Sancho McCann),ryandesign (Ryan Carsten Schmidt)
Port:

Description

I'm submitting a unified diff of the changes to the boost portfile. This brings boost from 1.33.1 to 1.34.

I removed the icu variant because this is automatically detected at the configuration stage.

Attachments (2)

Portfile.diff (4.5 KB) - added by sanchom (Sancho McCann) 17 years ago.
boost 1.33.1 -> boost 1.34 portfile upgrade
Portfile.2.diff (739 bytes) - added by sanchom (Sancho McCann) 17 years ago.
boost 1.34 portfile diff now includes icu variant

Download all attachments as: .zip

Change History (13)

Changed 17 years ago by sanchom (Sancho McCann)

Attachment: Portfile.diff added

boost 1.33.1 -> boost 1.34 portfile upgrade

comment:1 Changed 17 years ago by nox@…

"I removed the icu variant because this is automatically detected at the configuration stage."

That's actually a very bad thing, if icu is then uninstalled, boost will be broken. icu dependency must be clearly stated in the port.

comment:2 Changed 17 years ago by nox@…

Cc: n.oxyde@… added

comment:3 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: n.oxyde@… sanchom@… ryandesign@… added; n.oxyde@… removed
Owner: changed from macports-dev@… to ryandesign@…

Committed in r26030; thank you.

comment:4 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)

Oh... sorry... I didn't see the comment by nox before I committed. Yes, I agree, the dependency on icu needs to be declared, as it was in the line you removed:

depends_lib             lib:libicuuc:icu

Note that we now prefer dependencies to be stated using the port: syntax (e.g. "depends_lib port:icu") instead of the lib: syntax.

comment:5 Changed 17 years ago by sanchom (Sancho McCann)

Okay, so I reinstated the icu variant. Do you want the diff from the previous 1.33.1 portfile to the current portfile with the icu variant reinstated?

comment:6 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)

Since I've already committed your previous diff, I'd prefer a diff against the portfile from r26030.

Changed 17 years ago by sanchom (Sancho McCann)

Attachment: Portfile.2.diff added

boost 1.34 portfile diff now includes icu variant

comment:7 Changed 17 years ago by sanchom (Sancho McCann)

new diff added

comment:8 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

Portfile.2.diff applied and +icu variant reinstated in r26109. Thanks.

comment:9 Changed 17 years ago by nox@…

Cc: n.oxyde@… removed
Priority: ExpectedNormal
Version: 1.4.42

comment:10 Changed 16 years ago by jmroot (Joshua Root)

Type: enhancementupdate

comment:11 Changed 16 years ago by (none)

Milestone: Port Updates

Milestone Port Updates deleted

Note: See TracTickets for help on using tickets.