#12211 closed enhancement (fixed)
RFE: "lint" action for Portfile verification
Reported by: | afb@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | MacPorts 1.6 |
Component: | base | Version: | 1.5 |
Keywords: | Cc: | ||
Port: |
Description
port needs a target to verify that Portfiles are following set criteria, such as required variables or character encoding. It also helps to check that whitespace use and declaration order is uniform.
USAGE: $ sudo port lint MacPorts zlib ---> Verifying Portfile for MacPorts ---> 0 errors and 0 warnings found. ---> Verifying Portfile for zlib Warning: Line 4 should be a newline (after PortSystem) Warning: Line 16 should be a newline (after long_description) Warning: Line 33 has trailing whitespace before newline ---> 0 errors and 3 warnings found.
Attachments (1)
Change History (8)
Changed 17 years ago by afb@…
Attachment: | macports-portlint.patch added |
---|
comment:1 Changed 17 years ago by afb@…
Milestone: | → Needs developer review |
---|
Should be good to go, for collecting some feedback...
Opinions on script gotten so far on the mailing list:
- tabs and whitespace in Portfiles should be free-form
- newline after long_description might be optional ?
- "knowing" the location of Portfile is bad practice
comment:2 Changed 17 years ago by jmpalacios (Juan Manuel Palacios)
Milestone: | Needs developer review → MacPorts base bugs |
---|
Milestone Needs developer review deleted
comment:3 Changed 17 years ago by nox@…
Milestone: | MacPorts base bugs → MacPorts base enhancements |
---|---|
Priority: | Expected → Normal |
Summary: | "lint" action for Portfile verification → RFE: "lint" action for Portfile verification |
This is a duplicate of #463.
comment:4 Changed 17 years ago by afb@…
This is not a duplicate of #463, it's the start of a fix/implementation for it.
It was requested that it was posted to Trac as a patch, rather than commited...
comment:6 Changed 17 years ago by afb@…
Resolution: | → fixed |
---|---|
Status: | new → closed |
Well, it's in. Enhancements should be new tickets.
(whitespace-checks and long_desc-newline removed, ignoring that knowing Portfile is "bad practice")
comment:7 Changed 15 years ago by jmroot (Joshua Root)
Milestone: | MacPorts Future → MacPorts 1.6 |
---|
macports-portlint.patch