Opened 17 years ago
Last modified 11 years ago
#12247 new defect
BUG: Makefiles require GNU make
Reported by: | afb@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Low | Milestone: | MacPorts Future |
Component: | base | Version: | 1.5 |
Keywords: | FreeBSD support | Cc: | cooljeanius (Eric Gallager), larryv (Lawrence Velázquez) |
Port: |
Description
The makefiles use some commands specific to GNU make, and don't work with BSD make.
Attachments (1)
Change History (11)
Changed 17 years ago by afb@…
Attachment: | macports-bsdmake.patch added |
---|
comment:1 Changed 17 years ago by jmpalacios (Juan Manuel Palacios)
Milestone: | → Needs developer review |
---|
Comments on the patch:
- For consistency's sake, would like to see a line like
[ "$(ARC)" = "yes" ] && ${MAKE} SVNTAG=${DISTARCTAG} PKGNAME=${DISTARCNAME} _dopkg
inbase/Makefile.in
rather than the one provided usingtest
explicitly; - Not sure if removing
ifneq ($(MAKECMDGOALS),distclean)
frombase/doc/Makefile
has any negative side effects, I haven't been able to spot any; - Not sure why we're exporting the deployment target in
base/src/pextlib1.0
and inbase/src/tclobjc1.0
and if removing theexport
keyword breaks anything, I'll let others chime in on that one.
Other than those three, the patch seems OK to me for inclusion.
-jmpp
comment:2 Changed 17 years ago by jmpalacios (Juan Manuel Palacios)
Keywords: | FreeBSD support added |
---|
comment:3 Changed 17 years ago by afb@…
"Not sure if removing ifneq ($(MAKECMDGOALS),distclean) from base/doc/Makefile has any negative side effects, I haven't been able to spot any;"
Don't think it should have any, since doc/Makefile is processed before rm -f Mk/macports.autoconf.mk
comment:4 Changed 17 years ago by afb@…
Priority: | Expected → Nice to have |
---|
comment:5 Changed 17 years ago by jmpalacios (Juan Manuel Palacios)
Milestone: | Needs developer review → MacPorts base bugs |
---|
Milestone Needs developer review deleted
comment:6 Changed 17 years ago by nox@…
Priority: | Nice to have → Low |
---|---|
Summary: | Makefiles require GNU make → BUG: Makefiles require GNU make |
comment:7 Changed 16 years ago by tobypeterson
Milestone: | MacPorts base bugs → MacPorts Future |
---|
Milestone MacPorts base bugs deleted
comment:9 Changed 11 years ago by cooljeanius (Eric Gallager)
The removal of the endif
s would be useful not just for compatibility with BSD make, but also for people who might want to try converting the Makefiles to automake
-generated ones: http://lists.gnu.org/archive/html/automake/2000-10/msg00107.html
macports-bsdmake.patch