#12311 closed defect (fixed)
BUG: Fix version comparison in macports_fastload.tcl
Reported by: | sfiera@… | Owned by: | sfiera@… |
---|---|---|---|
Priority: | Normal | Milestone: | MacPorts 1.5 |
Component: | base | Version: | |
Keywords: | Cc: | ||
Port: |
Description
This is to reiterate a point I made to the developer list: macports_fastload performs an erroneous version comparison due to a list index being out-of-bounds. There happens to be an easier way of doing this version comparison in package vcompare
(like rpm-vercomp, but it only deals with integral components). An attached diff would make this change.
Note: previous versions of Tcl did not necessarily return the full version string in info patchlevel
so I verify that the version is a valid version string (\d+\.\d+\.\d+
) first.
Also note: I had commented about the catch
statements in my mail to -dev as well; having gained a greater understanding of what these statements are doing, I still don't feel they're necessary, though I no longer see a particular reason to remove them.
Attachments (1)
Change History (7)
Changed 17 years ago by sfiera@…
Attachment: | fastload.patch added |
---|
comment:1 Changed 17 years ago by sfiera@…
Summary: | Fix version comparison, catch statements in macports_fastload.tcl → Fix version comparison in macports_fastload.tcl |
---|
comment:2 Changed 17 years ago by kballard (Lily Ballard)
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 17 years ago by jmpalacios (Juan Manuel Palacios)
Milestone: | Needs developer review → MacPorts base bugs |
---|
Milestone Needs developer review deleted
comment:4 Changed 17 years ago by nox@…
Priority: | Not set → Normal |
---|---|
Summary: | Fix version comparison in macports_fastload.tcl → BUG: Fix version comparison in macports_fastload.tcl |
Version: | 1.5.0 |
comment:5 Changed 16 years ago by tobypeterson
Milestone: | MacPorts base bugs → MacPorts Future |
---|
Milestone MacPorts base bugs deleted
comment:6 Changed 15 years ago by jmroot (Joshua Root)
Milestone: | MacPorts Future → MacPorts 1.5 |
---|
Ok, committed in r27127