#12548 closed enhancement (fixed)
Add +proxy variant for irssi port
Reported by: | alakazam@… | Owned by: | sfiera@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 1.5.0 |
Keywords: | Cc: | sfiera@… | |
Port: |
Description
The default configuration options for the irssi port include the --without-proxy
option which disables the irssi proxy module.
Enabling it however works correctly, and I suggest adding a irssi +proxy
variant.
(I will attach a patch)
Attachments (1)
Change History (6)
Changed 17 years ago by alakazam@…
Attachment: | irssi-Portfile.patch added |
---|
comment:1 Changed 17 years ago by sfiera@…
Cc: | sfiera@… added |
---|---|
Owner: | changed from macports-dev@… to sfiera@… |
Status: | new → assigned |
Does the proxy option add any additional dependencies, or significantly lengthen the compile time? If not, I would be inclined to just fold it in as a default--there's no reason to make it a variant if there's a very minimal cost to add it.
comment:2 Changed 17 years ago by alakazam@…
It does not add any dependencies. I will check the difference in compile times, but irssi's compile time is not very long.
I agree using --with-proxy
as a default is perfectly reasonable.
comment:3 Changed 17 years ago by alakazam@…
Checking compile times gives the following times
Using --with-proxy
:
User: 40,70s System: 33,49s Percent: 87% Cmd: sudo port install irssi
Using the current Portfile :
User: 39,99s System: 33,08s Percent: 61% Cmd: sudo port install irssi
comment:4 Changed 17 years ago by sfiera@…
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Alright then, irssi-proxy enabled in r28204.
comment:5 Changed 16 years ago by (none)
Milestone: | Port Enhancements |
---|
Milestone Port Enhancements deleted
Patch to add +proxy variant