Opened 17 years ago
Closed 14 years ago
#12555 closed defect (fixed)
BUG: hrsh2csv fix for Intel
| Reported by: | cssdev | Owned by: | cssdev |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.5.0 |
| Keywords: | Cc: | cssdev, ryandesign (Ryan Carsten Schmidt), jmpalacios (Juan Manuel Palacios) | |
| Port: | hrsh2csv |
Description
hrsh2csv uses a configure-time setting to account for the endian ordering. Fix the port so that the macro is not disabled when building on an Intel platform. The port currently fails to process PDB files, as it expects a little endian platform.
Attachments (3)
Change History (12)
Changed 17 years ago by cssdev
| Attachment: | patch-Portfile.diff added |
|---|
comment:2 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | css@… ryandesign@… added |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
r28197 broke the build on PowerPC, because now it's trying to patch the Makefile before it's been extracted. It also broke the portindex, when indexing occurs on a PowerPC machine (which it currently does).
I was also going to suggest looking explicitly at the endian variable, rather than using the powerpc platform selector.
I recommend applying the attached patch hrsh2csv-endian.diff. I hope this fixes it. It is untested, except insofar as the endian check was copied out of the working wine port.
Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | hrsh2csv-endian.diff added |
|---|
comment:3 Changed 17 years ago by cssdev
That fix seems to work fine. I tested it building on my MacBook Pro, but I no longer have access to a PowerPC Mac.
Changed 17 years ago by cssdev
| Attachment: | powerpc-preconfigure.diff added |
|---|
What about this approach of using pre-configure to keep the modification within a platform variant?
comment:4 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | jmpp@… added |
|---|
jmpp has committed a fix for the issue in r28318. I still would have preferred my fix in hrsh2csv-endian.diff because my fix handles all big-endian architectures, not just powerpc.
comment:5 Changed 17 years ago by jmpalacios (Juan Manuel Palacios)
Hey Ryan! Had completely forgotten about this ticket, please don't feel like I ignored it ;-) Feel free to commit your patch if you feel it does the job better than mine!
-jmpp
comment:6 follow-up: 7 Changed 16 years ago by blb@…
Was there ever a consensus on this issue? Also, should this port list universal_variant no for now?
comment:7 Changed 16 years ago by cssdev
| Port: | hrsh2csv added |
|---|
Replying to blb@…:
Also, should this port list universal_variant no for now?
Yes, it probably should, as it's not currently a universal-friendly port. As for the endian issue, I like the most general solution available. I can adjust the Portfile accordingly.
comment:9 Changed 14 years ago by jmroot (Joshua Root)
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
This appears to be long since fixed.
Create a powerpc platform variant for the removal of byte order switching