Opened 17 years ago

Closed 17 years ago

Last modified 16 years ago

#12656 closed update (fixed)

neon update to 0.26.4.

Reported by: nox@… Owned by: danielluke (Daniel J. Luke)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: danielluke (Daniel J. Luke), nox@…
Port:

Description

Changes:

  • Updated to 0.26.4.
  • Added build dependency pkgconfig.
  • Added doc variant and standard doc installation.
  • Added pre-test procedure from subversion port for the DYLD_LIBRARY_PATH env variable.
  • Added sha1 and rmd160 checksums.
  • Fixed livecheck.

Attachments (1)

neon-0.26.4.diff (2.4 KB) - added by nox@… 17 years ago.

Download all attachments as: .zip

Change History (12)

Changed 17 years ago by nox@…

Attachment: neon-0.26.4.diff added

comment:1 Changed 17 years ago by danielluke (Daniel J. Luke)

Resolution: fixed
Status: newclosed

Version bump, pre-test procedure, and livecheck committed.

Neon builds fine without pkgconfig (but just uses the macports one if it's there) so I don't think the build dependency is necessary.

comment:2 Changed 17 years ago by nox@…

Why not commit the doc variant?

comment:3 Changed 17 years ago by danielluke (Daniel J. Luke)

neon already installs documentation, the additional files are not useful (upstream provides documentation with the default install and doesn't feel it's necessary to have those extra files copied over).

comment:4 Changed 17 years ago by nox@…

The default documentation is useful only if you are a developer (why common user should care about API reference?), that's why I've made it into a variant.
The other files are ChangeLog and all, they _are_ useful.

comment:5 Changed 17 years ago by danielluke (Daniel J. Luke)

It's a library, any documentation is targeted to developers.

I don't think it's worth the added portfile complexity to _not_ install documentation that upstream has install by default. Of the other files, only the ChangeLog might be interesting, and I'm not convinced that it needs to be installed (as it's usually only useful when first upgrading).

comment:6 Changed 17 years ago by nox@…

Which complexity? It's just a matter of disabling a make target dependency.

comment:7 Changed 17 years ago by danielluke (Daniel J. Luke)

It has to track future changes to the makefile and also requires a doubling of the test-builds I have to do before committing it (as I then have to build with +doc and without +doc to make sure it still works).

If files like these (AUTHORS BUGS ChangeLog NEWS README THANKS TODO) are really desired to be installed, it might make more sense to build an equivalent to the +universal variant (so that base/ adds the +doc variant and installs any/all of those files if they exist) instead of pushing a bunch of similar code into many portfiles.

comment:8 Changed 17 years ago by nox@…

these filenames differs from one port to another. The only thing that should be provided by MacPorts is a command like Portage's dodoc which install file to the docdir and create it if it does not exist.

By the way, these are not the files that should be a variant, the ones that should really be one are API reference.

Tracking the changes in the Makefile would take at most 3 seconds, and a little reading through the top-level install procedure remove the bother of double testing. If you really want to test with or without it, you just have to do the destroot twice, that's a very short amount of time.

comment:9 Changed 17 years ago by danielluke (Daniel J. Luke)

ChangeLog etc files - I still don't see a use for them (especially not as a default install). This is probably a discussion to have on the mailing list, though, as if there is consensus there that they should be installed by every port, then I'll update my ports to do so.

API reference files - I don't really think we should generally be preventing documentation install when the upstream 'make install' wants to install it.

More testing overhead - you can't just run destroot twice with different variants unless you hack the state file.

comment:10 Changed 16 years ago by jmroot (Joshua Root)

Type: enhancementupdate

comment:11 Changed 16 years ago by (none)

Milestone: Port Updates

Milestone Port Updates deleted

Note: See TracTickets for help on using tickets.