UPDATE: ldapvi to 1.7

[kajtzu@…]

ldapvi is version 1.5 in macports, attaching a trivial patch for version 1.7.

HTH

Kaj

[ryandesign (Ryan Carsten Schmidt)]

Not committing this, because

• the revision field needs to be removed, and
• the +sasl variant fails because the patch fails to apply

If you can fix these issues and attach a new patch, I'll have another look.

[kajtzu@…]

I don't believe the patch is necessary, the README states:

1.6 2006-11-04 New features:

• SASL support (thanks to Perry Nguyen)

I did fix the +sasl variant though, it just requires a dependency on cyrus-sasl2. Portfile patch attached.

[kajtzu@…]

updated portfile with sasl working

[ryandesign (Ryan Carsten Schmidt)]

• Your new patch ldapvi-1.7-Portfile2.patch removes the # $Id$ header from the first line of the portfile, which is no good; that should stay there.
• The dependency on the cyrus-sasl2 port that you put in the sasl variant doesn't make sense because the port already always depends on the openldap port, and the openldap port already always depends on the cyrus-sasl2 port. So this leaves an empty sasl variant. So should the sasl variant just be removed?
• The port installs its manpage directly to ${prefix}/man/man1/ldapvi.1, bypassing the destroot, thus it doesn't get listed in "port contents" and sticks around if the port is uninstalled. I fixed this by changing --mandir=${prefix}/share/man to --mandir=\\\${prefix}/share/man.
• I removed --infodir=${prefix}/share/info since the port doesn't seem to install any info pages.
• The port installs its documentation directly to ${prefix}/share/doc/ldapvi, bypassing the destroot. I don't know how to fix this (--docdir appears to have no effect).
• I changed the lib:libpopt:popt dependency to port:popt since lib:X:X-style dependencies shouldn't be used unless there's a really good reason to.
• The port links with the system's libncurses in /usr/lib. It should be changed to depend on the MacPorts libncurses in ${prefix}/lib. I don't know how to tell it to do this.
• The port links with the MacPorts readline port but does not declare a dependency on readline. I fixed this.

[ryandesign (Ryan Carsten Schmidt)]

partial fix; hopefully someone else can complete it

[kajtzu@…]

Oops, didn't realize openldap contained sasl already. That's okay. I think the variant can be removed as SASL would always be built in.

I improved some more on Portfile3:

• fixed the manpage and documentation installation locations differently, by patching GNUmakefile.in. File is GNUmakefile-paths.patch

  % port contents ldapvi                                                                      
  Port ldapvi contains:
    /opt/local/bin/ldapvi
    /opt/local/share/doc/ldapvi/bg.png
    /opt/local/share/doc/ldapvi/html.xsl
    /opt/local/share/doc/ldapvi/manual.css
    /opt/local/share/doc/ldapvi/manual.xml
    /opt/local/share/man/man1/ldapvi.1.gz
  

• Made it use ncurses before curses by patching configure.in and regenerating it before the build. File is configure-in.patch

[simon@…]

Committed in [30912] as all outstanding issues were fixed and it works fine. Thanks for your help.

[(none)]

Milestone Port Updates deleted