libgtop2 (2.20) doesn't build on 10.4.11

[paulbeard@…]

 gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I../.. -I../../sysdeps/stub -I../../include -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/usr/X11R6/include -I/opt/local/include -Winline -Wall -std=gnu89 -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -O2 -lintl -MT proclist.lo -MD -MP -MF .deps/proclist.Tpo -c proclist.c  -fno-common -DPIC -o .libs/proclist.o
proclist.c:48: error: conflicting types for 'glibtop_get_proclist_s'
../../include/glibtop/proclist.h:87: error: previous declaration of 'glibtop_get_proclist_s' was here
make[3]: *** [proclist.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
Warning: the following items did not execute (for libgtop): org.macports.destroot org.macports.build

[paulbeard@…]

logfile with -d switch thrown

[macosforge.lbn@…]

Building with libgtop-2.21.1 seems to work. Here's the modified Portfile to use 2.21.1

[macosforge.lbn@…]

Need to update gnome-system-monitor (add gtkmm dep) also if you try and use libgtop-2.21.1

[paulbeard@…]

I get errors on both patches.

[...macports.org/release/ports/gnome/libgtop]# patch -p0 < libgtop-portfile.diff patching file Portfile patch unexpectedly ends in middle of linepatch: malformed patch at line 41:

[...release/ports/gnome/gnome-system-monitor]# patch -p0 < gnome-system-monitor-portfile.diff patching file Portfile Hunk #1 FAILED at 1. patch unexpectedly ends in middle of line Hunk #2 FAILED at 10. 2 out of 2 hunks FAILED -- saving rejects to file Portfile.rej

[rhwood@…]

I am reluctant to apply the patch to use the upstream unstable version of libgtop2, but will look at it this weekend. GNOME packages (for the most part) use even minor version numbers to indicate stable releases and odd minor version numbers to indicate stable releases (in x.y.z, y is the minor version number).

[rhwood@…]

changeset:31693 and chnageset:31694 should resolve this. Please reopen if they don't.

[rhwood@…]

Replying to rhwood@macports.org:

chnageset:31694

That should be changeset:31694

[(none)]

Milestone Port Bugs deleted