#13439 closed defect (fixed)
PATCH: sysutils/lsdvd fails to build with latest libdvdread
| Reported by: | ecronin (Eric Cronin) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.6.0 |
| Keywords: | Cc: | ||
| Port: |
Description
maintainer patch
Attachments (1)
Change History (6)
Changed 17 years ago by ecronin (Eric Cronin)
| Attachment: | lsdvd.patch added |
|---|
comment:1 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from macports-dev@… to ryandesign@… |
|---|
comment:2 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 Changed 17 years ago by ecronin (Eric Cronin)
Not sure if it was 10.5 or macports trunk that did it (my money is on 10.5 and the UNIXification) but necessary types were not defined yet when the libdvdread headers were imported. Moving <stdint.h> before the libdvdread #include fixed this... Sorry for the misleading blame-pointing, was still getting a feel for how 10.5 broke things at the time I filed this.
comment:4 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
Ah, ok. Well, I just build MacPorts 1.7.0 from trunk and rolled back the portfile to r32001 without the patches, and it still built fine on Tiger, so I'm guessing it's Leopard causing the problem you fixed. I updated the commit message for r32002 accordingly (though that change might not show up in Trac right away).
Note: See
TracTickets for help on using
tickets.
I committed this change in r32002 (except that I changed the names of the patchfiles to conform to MacPorts guidelines).
I'm curious what "latest" version of libdvdread you're talking about though. 0.9.7 seems to be the latest version released, and on Mac OS X 10.4.11 with Xcode 2.4.1 on a MacBook Pro, I had no trouble building lsdvd, even without these patches.