yasm 0.6.2_0 forgotten dependencies on libiconv and gettext

[ryandesign (Ryan Carsten Schmidt)]

yasm 0.6.2_0 links with libiconv and gettext:

$ ldd /opt/local/bin/yasm 
/opt/local/bin/yasm:
        /opt/local/lib/libintl.8.dylib (compatibility version 9.0.0, current version 9.2.0)
        /opt/local/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 88.3.9)
        /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 368.31.0)
$

but the port does not declare these dependencies:

$ port deps yasm
yasm has no dependencies
$

The port should declare these dependencies, or force yasm not to link against these libraries.

[bytestorm@…]

Adds nls variant requesting deps or removes nls from build

[bytestorm@…]

Oops, that's embarrasing; this diff declares the dependancies in a variant if nls support is required. Thanks for catching that.

[ryandesign (Ryan Carsten Schmidt)]

Actually I don't think there should be a variant for this. Who'd want to turn it off? Just keep it on all the time, but declare the dependencies. (We've had arguments on the list before specifically about not adding an "nls" variant to ports.)

[bytestorm@…]

0.6.2 -> 0.6.2_2 diff, no variant, just adds the deps to the port.

[bytestorm@…]

Ok, I missed that discussion. 0.6.2_2 allows nls by default, declaring deps for libiconv and gettext all the time. I considered a nonls variant, but again, who would want to turn it off? Diff is based off of 0.6.2_0 already in the ports tree.

[ryandesign (Ryan Carsten Schmidt)]

Committed the update to 0.6.2_2 in r32033. Thanks.

FYI: You shouldn't remove the $Id$ header line in your patches in the future. The $Id$ line belongs at the top of every portfile.

[(none)]

Milestone Port Bugs deleted