osxvnc: allow non-universal build

[anton@…]

Sometimes the extra weight of universal builds is unneeded. This package, by default, builds universal. Attached is a patch that retains this behavior, but allows variant -universal to build an arch specific binary.

[nox@…]

You don't need to use uname -m here, just use $(NATIVE_ARCH) and ​xcodebuild will be happy.

[jmroot (Joshua Root)]

IMO it would be better to remove universal as a default variant, like other ports:

variant universal {}
if { [variant_isset universal] } {
    xcode.build.settings ARCHS='i386 ppc'
} else {
    xcode.build.settings ARCHS=$(NATIVE_ARCH)
}

[ryandesign (Ryan Carsten Schmidt)]

I'm happy to change osxvnc so that universal is not the default. I just didn't know exactly how to do it.

"xcode.build.settings ARCHS=$(NATIVE_ARCH)" is not the solution; the port self-destructs with the message "can't read "(NATIVE_ARCH)": no such variable".

"xcode.build.settings ARCHS=\$(NATIVE_ARCH)" isn't it either; this passes $(NATIVE_ARCH) on to the xcodebuild line, but that then complains with "sh: line 1: NATIVE_ARCH: command not found"

"xcode.build.settings ARCHS=\\\$\\(NATIVE_ARCH\\)" gets past the errors and the build completes, but still ends up being universal.

I'm not keen on calling out to uname -m...

I'll do it the way Anthony Ramine has been doing in his ports for some time. Committed in r35717. Thanks for all the suggestions though!

No revision bump is necessary. Users who had the port installed previously automatically had the +universal variant selected. Users who now install the port will get it without +universal, but can select +universal if they want it.

[(none)]

Milestone Port Enhancements deleted