BUG: mailsync 5.2.1 build fails

[seth_macports@…]

Build of mailsync 5.2.1 fails with the errors included below.

uname -a: Darwin samsara.local 9.1.0 Darwin Kernel Version 9.1.0: Wed Oct 31 17:46:22 PDT 2007; root:xnu-1228.0.2~1/RELEASE_I386 i386

port --version MacPorts 1.600

port sync port install mailsync

--->  Building mailsync with target all
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_mail_mailsync/work/mailsync-5.2.1" && make all " returned error 2
Command output: make  all-recursive
Making all in src
/usr/bin/g++-4.0 -fno-operator-names -O2  -L/opt/local/lib -o mailsync  mailsync_main.o commandline.o configuration.o types.o mail_handling.o c-client_callbacks.o utils.o store.o channel.o msgid.o msgstring.o /opt/local/lib/libc-client4.a -dynamic -O2 -Wl,-search_paths_first -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -lresolv -L/opt/local/lib  -lssl -lcrypto 
Undefined symbols:
  "_pam_set_item", referenced from:
      _Checkpw in libc-client4.a(osdep.o)
  "_pam_setcred", referenced from:
      _checkpw_cleanup in libc-client4.a(osdep.o)
      _Checkpw in libc-client4.a(osdep.o)
  "_pam_authenticate", referenced from:
      _Checkpw in libc-client4.a(osdep.o)
  "_pam_start", referenced from:
      _Checkpw in libc-client4.a(osdep.o)
  "_pam_acct_mgmt", referenced from:
      _Checkpw in libc-client4.a(osdep.o)
  "_pam_end", referenced from:
      _checkpw_cleanup in libc-client4.a(osdep.o)
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[2]: *** [mailsync] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Error: Status 1 encountered during processing.

[seth_macports@…]

It appears that the problem here is that the default cclient target is now "oxp" which links against pam, so mailsync needs to have some awareness of pam as well. But the configure step doesn't find the pam headers, which are not in a "security" subdirectory as the configure script expects; this also breaks the pam test program as it tries to include "security/pam_appl.h"; removing "security" in both places fixes this. Once that's fixed, it doesn't find the cclient headers, fixed by adding "/opt/local/" to the CCLIENTLOCATIONS. Finally there are problems removing a directory it expects to be a file, "conftest.dSYM" (I think this might ultimately be an autoconf bug). But after these issues are addressed, it builds fine.

I've never submitted a patch before, but I'll try to figure it out.

[seth_macports@…]

Candidate for new files/patch-configure

[seth_macports@…]

Candidate for new Portfile

[seth_macports@…]

I've attached new candidates for the Portfile file and files/patch-configure file that address all of the problems I cited above. The salient difference in the Portfile is removal of the "--without-pam" configure.args line. I'm not sure (whether|how) to correctly indicate the new pam dependency inherited from linking to cclient; cclient has no such indication itself.

Another point to review is the "rm -rf conftest*" modification to eliminate the autoconf-related .dSYM error. I based my patch on the discussion here: ​Nabble Mac OS X Leopard conftest.dSYM error discussion. This may not actually be absolutely necessary, as mailsync appears to build successfully even with these errors.

[kballard (Lily Ballard)]

Please submit a single diff for your changes rather than new copies. It is unlikely that your work will be committed unless we can see what changes you made easily.

You can produce a patchfile with svn diff > Portfile.patch.

[seth_macports@…]

per eridius@: an svn diff of changes to fix the pam dependency problem that is the source of the problem described in this ticket.

[kballard (Lily Ballard)]

Ok, committed in r32613, thanks

[(none)]

Milestone Port Bugs deleted

[dave@…]

Well, I'm still having a PAM dependency problem. My build log is attached.

[dave@…]

Adding

configure.ldflags	"-lpam"

to the Portfile fixes it for me.