#14031 closed enhancement (wontfix)
port lint should check for whitespace before/after variant descriptions
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | base | Version: | 1.7.0 |
Keywords: | Cc: | raimue (Rainer Müller) | |
Port: |
Description
The syntax of variant descriptions lends itself to being written incorrectly, resulting in unintended whitespace before or after the description.
Wrong:
variant foo description { foodesc } { ... } variant bar description " bardesc " { ... }
Right:
variant foo description {foodesc} { ... } variant bar description "bardesc" { ... }
port lint
should warn of whitespace before or after a variant description.
Change History (5)
comment:1 Changed 17 years ago by raimue (Rainer Müller)
Cc: | raimue@… added |
---|
comment:2 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
That would be another way to go. Probably a better way. I filed that as a separate ticket #14037. If we do that, then we don't need to change port lint
.
comment:3 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
Owner: | changed from macports-tickets@… to ryandesign@… |
---|
#14037 has been implemented (good job, Rainer!) so we don't need any port lint
changes after all.
comment:4 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → wontfix |
---|---|
Status: | new → closed |
comment:5 Changed 15 years ago by jmroot (Joshua Root)
Milestone: | MacPorts Future |
---|
Note: See
TracTickets for help on using
tickets.
In my opinion, port variants should strip leading and trailing whitespace on variant descriptions.