livecheck.distname is not properly escaped in livecheck.regex

[ryandesign (Ryan Carsten Schmidt)]

livecheck.distname is not being properly escaped before being put into livecheck.regex. I noticed this problem while trying to update the livecheck for osxvnc, setting livecheck.distname Vine Server(OSXvnc). With livecheck.check sourceforge, this results in the regex "<title>Vine Server(OSXvnc) (.*) released.*</title>" which is incorrect. The regex I wanted was "<title>Vine Server\(OSXvnc\) (.*) released.*</title>". There must be a Tcl function we can use which would properly escape a string for use in a regular expression, like ​preg_quote() in php.

Looking through all ports, I see that fixing this will break the livecheck in the portfiles for fusefs and spotlightfs, which currently assume this bug exists.

[afb@…]

Replying to ryandesign@macports.org:

There must be a Tcl function we can use which would properly escape a string for use in a regular expression, like ​preg_quote() in php.

Doesn't look that way, but then again it isn't impossible to just add one either.

[raimue (Rainer Müller)]

Fixed in r34667.

[raimue (Rainer Müller)]

Now really fixed in r34693, the previous commit broke other regexes.

[tobypeterson]

Milestone MacPorts base bugs deleted