port lint complains about trailing spaces on blank lines

[ryandesign (Ryan Carsten Schmidt)]

When first implemented, port lint complained about trailing whitespace on blank lines. The code in portlint.tcl checked for this condition to decide whether to print the warning:

[string match "* " $line] || [string match "*\t" $line]

afb committed r28568 which was supposed to fix it, by changing the check to this:

[string match "* " $line] || [string match "*\t" $line] && [string trim $line] != ""

But in fact, this only fixed it if the trailing whitespace was a tab. If the trailing whitespace was a space, the erroneous warning is still printed. The check should have been:

([string match "* " $line] || [string match "*\t" $line]) && [string trim $line] != ""

But this can all be simplified to a single regular expression:

[regexp {\S[ \t]+$} $line]

[ryandesign (Ryan Carsten Schmidt)]

Fixed in r33705.

[afb@…]

parentheses in Tcl always traps me up...

[ryandesign (Ryan Carsten Schmidt)]

Yeah, I was a little surprised too! I didn't expect to need parens there. In any case, I like the regular expression solution better. :)

[tobypeterson]

Milestone MacPorts base bugs deleted