Opened 17 years ago

Closed 16 years ago

Last modified 16 years ago

#14190 closed defect (fixed)

BUG git-core @1.5.3.7_0+doc launching git-gui crashes

Reported by: carson@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: bryan@…, nox@…
Port:

Description (last modified by jmpalacios (Juan Manuel Palacios))

with git-core @1.5.3.7_0+doc launching git-gui causes a malloc error on start: 

$ git-gui
wish(76152) malloc: *** error for object 0x5adeb8: Non-aligned pointer being freed
*** set a breakpoint in malloc_error_break to debug
X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  152 (RENDER)
  Minor opcode of failed request:  4 (RenderCreatePicture)
  Serial number of failed request:  426
  Current serial number in output stream:  450

As a test case try: 

git clone git://springlobby.info/git/koshi/springlobby.git
cd springlobby
git-gui

Description:

When launching git-gui program fails noisily. Other git components appear to function normally.

Comments: Verified that git-gui on ubuntu launches without error. Ubuntu version is 1.5.2.5

Change History (8)

comment:1 Changed 17 years ago by jmpalacios (Juan Manuel Palacios)

Description: modified (diff)
Milestone: → Port Bugs

comment:2 Changed 17 years ago by skymoo (Adam Mercer)

I can't reproduce this on Intel Leopard: 

[ram@skymoo ~]$ port installed | grep git-core
  git-core @1.5.3.7_0+doc+svn (active)
[ram@skymoo ~]$ git clone git://springlobby.info/git/koshi/springlobby.git
Initialized empty Git repository in /Users/ram/springlobby/.git/
remote: Counting objects: 12330, done.
remote: Compressing objects: 100% (5272/5272), done.
Indexing 12330 objects...
remote: Total 12330 (delta 9302), reused 9438 (delta 6975)
 100% (12330/12330) done
Resolving 9302 deltas...
 100% (9302/9302) done
[ram@skymoo ~]$ cd springlobby/
[ram@skymoo springlobby]$ git-gui
X Error of failed request:  RenderBadPicture (invalid Picture parameter)
  Major opcode of failed request:  153 (RENDER)
  Minor opcode of failed request:  7 (RenderFreePicture)
  Picture id in failed request: 0x200104
  Serial number of failed request:  2241
  Current serial number in output stream:  2256
[ram@skymoo springlobby]$

git-gui displays and works without issue.

comment:3 Changed 17 years ago by maccheck@…

Cannot reproduce it on a local port of git-core 1.5.4+doc+svn (see ticket #13956) as well. 

dargo:temp markus$ port installed | grep git-core
  git-core @1.5.4_0+doc+svn (active)
dargo:temp markus$ git clone git://springlobby.info/git/koshi/springlobby.git
Initialized empty Git repository in /Users/markus/temp/springlobby/.git/
remote: Counting objects: 12330, done.
remote: Compressing objects: 100% (5272/5272), done.
remote: Total 12330 (delta 9302), reused 9438 (delta 6975)
Receiving objects: 100% (12330/12330), 3.07 MiB | 711 KiB/s, done.
Resolving deltas: 100% (9302/9302), done.
dargo:temp markus$ cd springlobby/
dargo:springlobby markus$ git-gui 
dargo:springlobby markus$

comment:4 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: bryan@… added

Cc'ing maintainer.

comment:5 Changed 16 years ago by nox@…

Cc: nox@… added

Does it still occur on 1.6.0.2?

comment:6 Changed 16 years ago by carson@…

In 1.6.0.2 it appears resolved, but git-gui is not in the path: 

carson@spinoza:~$ which git
/opt/local/bin/git
carson@spinoza:~$ which git-gui
# not in path
carson@spinoza:~$ /opt/local/var/macports/software/git-core/1.6.0.2_2+doc/opt/local/libexec/git-core/git-gui
# but can execute from here

comment:7 Changed 16 years ago by nox@…

Resolution: → fixed
Status: new → closed

git-gui is a porcelain command of git, you can either run git gui or /opt/local/libexec/git-core/git-gui. I'm closing the ticket.

comment:8 Changed 16 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.