Opened 17 years ago

Closed 17 years ago

Last modified 16 years ago

#14579 closed enhancement (fixed)

p5-dbd-mysql: add mysql5-devel support

Reported by: ebgssth@… Owned by: narf_tm@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: mysql perl Cc:
Port:

Description

p5-dbd-mysql currently doesn't work with mysql5-devel. Please change this to use mysql5-devel when it's installed on the machine.

Attachments (1)

mysql5.diff (3.4 KB) - added by ebgssth@… 17 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 17 years ago by ebgssth@…

This was not as easy as I thought. I tried building DBD::mysql with MySQL 5.1.23, current mysql-devel version but it failed with these error

dbdimp.c: In function 'mysql_st_next_results':
dbdimp.c:2763: error: 'NET' has no member named 'last_errno'
dbdimp.c: In function 'mysql_st_fetch':
dbdimp.c:3365: error: 'NET' has no member named 'last_errno'
make: *** [dbdimp.o] Error 1

dbdimp.c: In function 'mysql_st_next_results':
dbdimp.c:2763: error: 'NET' has no member named 'last_errno'
dbdimp.c: In function 'mysql_st_fetch':
dbdimp.c:3365: error: 'NET' has no member named 'last_errno'
make: *** [dbdimp.o] Error 1

This is because MySQL5.1.23 has renamed et->last_err* to net->client_last_err*. See http://bugs.mysql.com/bug.php?id=34655

This problem is already fixed and will be in 5.1.24-rc. Until it released, we need a patch to revert the variable names.

http://mysql.bkbits.net:8080/mysql-5.1/?PAGE=cset&REV=47c6f5a2BwqDa9RrRzHtmo9cSUYwgw

Changed 17 years ago by ebgssth@…

Attachment: mysql5.diff added

comment:2 Changed 17 years ago by ebgssth@…

Backported MySQL5.1 Changeset 1.2551 to mysql5-devel/Portfile.

And changed p5-dbd-mysql to use mysql5-devel when it is installed

comment:3 Changed 17 years ago by jmroot (Joshua Root)

Cc: narf_tm@… removed
Owner: changed from macports-tickets@… to narf_tm@…

comment:4 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)

Summary: Please add mysql5-devel support to p5-dbd-mysqlp5-dbd-mysql: add mysql5-devel support

I will apply a patch to mysql5-devel 5.1.23-rc to fix this. See #14387 for progress on this issue.

comment:5 Changed 17 years ago by ebgssth@…

No answer from the maintainer more than a week. Could someone with commit right checkin this for me? I really need this patch to be commited for using another requested port, innotop

comment:6 Changed 17 years ago by narf_tm@…

Resolution: fixed
Status: newclosed

Applied patch file in changeset [35113].

comment:7 Changed 16 years ago by (none)

Milestone: Port Enhancements

Milestone Port Enhancements deleted

Note: See TracTickets for help on using tickets.