post-commit lint script should handle Portfiles anywhere in repository

[ryandesign (Ryan Carsten Schmidt)]

If I commit changes to a Portfile in trunk/dports/*/* a script​ runs which checks the Portfile syntax and emails any errors to the committer and maintainer. But if I have a Portfile elsewhere in the repository, such as under users/*/*, then the script emails me an error instead:

Portfile: pure-devel

Error: Unable to open port: Could not find Portfile in /tmp/mp_lint/36446/ryandesign/pure-devel

trunk/dports seems to be hardcoded into the script. But the script should support Portfiles, wherever in the repository they may be.

William said he doesn't have time to look into this right now so I may take a look.

[wsiegrist@…]

I've modified the lint script on the server. Please verify this is fixed next time you touch a Portfile outside of trunk/dports?

[(none)]

Milestone Website & Documentation deleted

[raimue (Rainer Müller)]

It works for me correctly when committing to my /users/raimue/ports directory, so I consider this fixed.

[ryandesign (Ryan Carsten Schmidt)]

You have directories in your ports directory for categories. I don't, because I don't need them.

[drkp (Dan Ports)]

I'm not sure it should run lint on portfiles not in trunk/dports at all.

r68605 just got me 84 lint report emails, mostly telling me that a portgroup file or dependency couldn't be located. No surprise, they're only in my users directory, and I don't really expect it to look there, but I'd rather not be flooded by emails when it doesn't find them...

[ryandesign (Ryan Carsten Schmidt)]

So... you're saying the server is now running lint on Portfiles not in trunk/dports? So... this ticket has been resolved?

To prevent the errors about the missing portgroup, feel free to put the new portgroup into the public tree already, even if it isn't quite done yet.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign@…:

So... you're saying the server is now running lint on Portfiles not in trunk/dports? So... this ticket has been resolved?

Oh, wait, I see, you too have category directories whereas I didn't. At the time I filed this ticket, it hadn't occurred to me to create category directories in my user directory. I suppose we could just officially recommend that people use category directories for ports in their user directory (if we don't already) and be done with it.

[raimue (Rainer Müller)]

We are no longer using Subversion, so I consider this to be no longer relevant. If someone wants a new lint job for the Git repository, that would be a separate issue.